Page MenuHomePhabricator
Create Task
Maniphest T266732

[cleanup] Replace deprecated Sanitizer::escapeId() with specific Sanitizer::escapeIdFor*() (tracking)
Closed, ResolvedPublic
Actions

Description

Deprecated since 1.30 (patch, T152540), it's still in use in some stagnant skins and a few extensions:
https://codesearch.wmcloud.org/search/?q=Sanitizer%3A%3AescapeId%5B%5E%5Cw%5D&i=nope&files=%5C.php&repos=

The new methods:

  • escapeIdForAttribute()
  • escapeIdForLink()
  • escapeIdForExternalInterwiki()

Details

SubjectRepoBranchLines +/-
Material.skin: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()mediawiki/skins/Materialmaster+1 -1
MetrolookTemplate: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()mediawiki/skins/Metrolookmaster+2 -2
ApexTemplate: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()mediawiki/skins/apexmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

• Demian created this task.Oct 29 2020, 2:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2020, 2:36 AM
• Demian added a project: User-Demian.Oct 29 2020, 2:37 AM
• Demian moved this task from Incoming to Awaiting Review on the User-Demian board.
gerritbot added a comment.Oct 29 2020, 3:15 AM

Change 637112 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/apex@master] ApexTemplate: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()

https://gerrit.wikimedia.org/r/637112

gerritbot added a project: Patch-For-Review.Oct 29 2020, 3:15 AM
gerritbot added a comment.Oct 29 2020, 7:37 AM

Change 637112 merged by jenkins-bot:
[mediawiki/skins/apex@master] ApexTemplate: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()

https://gerrit.wikimedia.org/r/637112

Maintenance_bot removed a project: Patch-For-Review.Oct 29 2020, 8:10 AM
gerritbot added a comment.Oct 30 2020, 7:41 AM

Change 637633 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Metrolook@master] MetrolookTemplate: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()

https://gerrit.wikimedia.org/r/637633

gerritbot added a project: Patch-For-Review.Oct 30 2020, 7:41 AM
gerritbot added a comment.Oct 30 2020, 7:43 AM

Change 637600 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Material@master] Material.skin: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()

https://gerrit.wikimedia.org/r/637600

• Demian moved this task from Awaiting Review to Awaiting Review - Trivial on the User-Demian board.Nov 1 2020, 11:52 PM
• Demian added a project: Technical-Debt.Nov 2 2020, 11:52 PM
• Demian moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.
Aklapper removed • Demian as the assignee of this task.Nov 8 2020, 10:21 AM

[Resetting assignee due to inactive user account]

gerritbot added a comment.Dec 2 2020, 7:02 PM

Change 637633 merged by jenkins-bot:
[mediawiki/skins/Metrolook@master] MetrolookTemplate: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()

https://gerrit.wikimedia.org/r/637633

gerritbot added a comment.Dec 2 2020, 7:17 PM

Change 637600 merged by jenkins-bot:
[mediawiki/skins/Material@master] Material.skin: Replace deprecated Sanitizer::escapeId() call with Sanitizer::escapeIdForAttribute()

https://gerrit.wikimedia.org/r/637600

Jdlrobson closed this task as Resolved.Dec 2 2020, 7:20 PM
Jdlrobson claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL