Page MenuHomePhabricator

[cleanup] Replace deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook (tracking)
Closed, ResolvedPublic

Description

Deprecated since 1.35 (T255698), used in:
https://codesearch.wmcloud.org/search/?q=addToBodyAttributes&i=nope&files=&repos=

Skins to patch / patches to merge (as of 2021-03-26):

  • Apex
  • BlueSpiceCalumma
  • DeskMessMirrored

Simple, no risk, good for beginners interested in skins.

Event Timeline

Change 637114 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/apex@master] SkinApex: Replace deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook

https://gerrit.wikimedia.org/r/637114

Change 637114 merged by jenkins-bot:
[mediawiki/skins/apex@master] SkinApex: Replace deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook

https://gerrit.wikimedia.org/r/637114

Demian moved this task from Awaiting Review to Awaiting Review - Trivial on the User-Demian board.
Demian moved this task from Awaiting Review - Trivial to Done on the User-Demian board.
Demian removed Demian as the assignee of this task.
Demian triaged this task as Lowest priority.

[Correction] Keeping open for skins:

  • BlueSpiceCalumma
  • DeskMessMirrored

Change 675077 had a related patch set uploaded (by Sahilgrewalhere; author: Sahilgrewalhere):
[mediawiki/skins/BlueSpiceCalumma@master] Replaced deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook (tracking)

https://gerrit.wikimedia.org/r/675077

Hey @Aklapper ! I think the issue for DeskMessMirrored is already solved...Please Checkout Once...Tagging you because @Demian is diabled.

I guess so - https://codesearch.wmcloud.org/search/?q=addToBodyAttributes
(PS: No need to ping; I don't have any special involvement here; I am only subscribed anyway.)

Aklapper removed a project: patch-welcome.
Aklapper updated the task description. (Show Details)
Aklapper removed a subscriber: Demian.

Change 681091 had a related patch set uploaded (by Pwirth; author: Sahilgrewalhere):

[mediawiki/skins/BlueSpiceCalumma@REL1_35] Replaced deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook (tracking)

https://gerrit.wikimedia.org/r/681091

Change 681091 merged by Dvogel hallowelt:

[mediawiki/skins/BlueSpiceCalumma@REL1_35] Replaced deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook (tracking)

https://gerrit.wikimedia.org/r/681091

Change 675077 merged by Dvogel hallowelt:

[mediawiki/skins/BlueSpiceCalumma@master] Replaced deprecated addToBodyAttributes() with onOutputPageBodyAttributes() hook (tracking)

https://gerrit.wikimedia.org/r/675077