Page MenuHomePhabricator
Create Task
Maniphest T266882

Remove SkinMinervaDefaultModules hook after 1.36 release
Closed, ResolvedPublic
Actions

Description

The SkinMinervaDefaultModules hook was deprecated in 1.36
After that release has occurred it has been removed from the codebase.

Details

Other Assignee
Jdlrobson
ProjectBranchLines +/-Subject
mediawiki/skins/MinervaNeuemaster+0 -2Remove SkinMinervaDefaultModules hook
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Oct 30 2020, 4:32 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 30 2020, 4:32 PM
Jdlrobson changed the task status from Open to Stalled.Oct 30 2020, 4:32 PM
Jdlrobson mentioned this in T256086: Deprecate SkinMinervaDefaultModules hook.
DannyS712 changed the task status from Stalled to Open.Jul 5 2021, 3:54 PM
gerritbot added a comment.Jul 5 2021, 3:55 PM

Change 703226 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/skins/MinervaNeue@master] Remove SkinMinervaDefaultModules hook

https://gerrit.wikimedia.org/r/703226

gerritbot added a project: Patch-For-Review.Jul 5 2021, 3:55 PM
DannyS712 added a subscriber: DannyS712.Jul 5 2021, 3:55 PM

I unstalled this because I assume it was stalled until after 1.36 was cut and master was version 1.37
Patch sent

DannyS712 moved this task from Blocker to To deprecate or remove on the MW-1.37-release board.Jul 7 2021, 10:22 PM
Jdlrobson added a parent task: T282045: [GOAL] Deprecate and remove skin code in preparation for 1.37.Jul 13 2021, 7:12 PM
Jdlrobson edited projects, added Readers-Web-Backlog (Kanbanana-FY-2020-21); removed Readers-Web-Backlog (Tracking).

Thanks @DannyS712 for unstalling this one! No known usages so can safely be removed.
https://codesearch.wmcloud.org/search/?q=SkinMinervaDefaultModules&i=nope&files=&excludeFiles=&repos=

Jdlrobson claimed this task.Jul 13 2021, 7:13 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson updated Other Assignee, added: DannyS712.
gerritbot added a comment.Jul 13 2021, 7:32 PM

Change 703226 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove SkinMinervaDefaultModules hook

https://gerrit.wikimedia.org/r/703226

DannyS712 closed this task as Resolved.Jul 13 2021, 7:42 PM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 13 2021, 7:42 PM
DannyS712 updated Other Assignee, added: Jdlrobson; removed: DannyS712.Jul 13 2021, 7:42 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 13 2021, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL