Page MenuHomePhabricator

Prevent custom amount field placeholder from being cut-off
Open, Needs TriagePublic

Description

When the banner form is displayed below the banner text, the placeholder in the custom amount field tends to be cut-off. We want to prevent this from happening.

Acceptance Criteria

  • In the banners for English Wikipedia the breakpoint that currently is at 1400px should be moved to 1300px.
  • In the banners for English and German Wikipedia below 1300px width (when the form is below the blue bubble)
    • the interval option of "bi-annual" ("halbjährlich") should not be displayed.
    • the custom amount field should have a fixed width to prevent the placeholder from being cut-off (110px seems fine in Firefox and Chrome).

Event Timeline

Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptOct 30 2020, 5:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AbbanWMDE claimed this task.Mon, Nov 2, 6:44 AM
AbbanWMDE moved this task from Heap to Doing on the WMDE-FUN-Funban-2020 board.

PR for English desktop banner: https://github.com/wmde/fundraising-banners/pull/411

@kai.nissen The min-width on the custom amount forces the amounts on the left off the screen on sizes under ~500px. Is this okay?

AbbanWMDE removed AbbanWMDE as the assignee of this task.Mon, Nov 2, 9:57 AM
AbbanWMDE moved this task from Doing to Code Review on the WMDE-FUN-Funban-2020 board.
AbbanWMDE added a subscriber: AbbanWMDE.