Page MenuHomePhabricator

Research how to inject PermissionManager into abstract SpecialPage
Open, Needs TriagePublic

Description

The SpecialPage class needs the PermissionManager service on every instance for permissions check.

The first idea is to set it from the factory on the created object, but PermissionManager needs the SpecialPageFactory itself and that results in a circular dependency.

No idea how to resolve it.

Event Timeline

Aklapper renamed this task from Reasearch how to inject PermissionManager into abstract SpecialPage to Research how to inject PermissionManager into abstract SpecialPage.Nov 2 2020, 7:12 AM

Change 643573 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/core@master] Inject PermissionManager into abstract SpecialPage class

https://gerrit.wikimedia.org/r/643573

Change 643573 abandoned by Umherirrender:
[mediawiki/core@master] Inject PermissionManager into abstract SpecialPage class

Reason:
May be needs another way to handle the injection and the way to provide the injected permission manager to all user of this special page.
Keep that open for another developer

https://gerrit.wikimedia.org/r/643573

May be not longer needed with the concept of Authority which may be could be used in special pages