Seen in beta logstash: Use of Revision::getQueryInfo was deprecated in MediaWiki 1.31. [Called from CharacterEditStats::getRevisionsFromHistory]
relevant code:
// The field renames are to be compatible with recentchanges table query if ( is_callable( [ Revision::class, 'getQueryInfo' ] ) ) { $revQuery = Revision::getQueryInfo( [ 'page' ] ); $revUserText = $revQuery['fields']['rev_user_text'] ?? 'rev_user_text'; } else { $revQuery = [ 'tables' => [ 'revision', 'page' ], 'joins' => [ 'page' => [ 'JOIN', 'rev_page = page_id' ], ] ]; $revUserText = 'rev_user_text'; }
Should this just be updated to use RevisionStore? The is_callable check complicates things - is this meant to work once Revision is removed, and just needs to check the version as well? The replacement use of RevisionStore should always be available, so I'm not sure what to do about the logic in the else branch