Page MenuHomePhabricator

omnipresent #contentSub element causes styling issues
Closed, DeclinedPublic

Description

The #contentSub element is always present, but does not have any content most of the times. Consequences:

  1. The Monobook and Vector skins do #contentSub { margin: 0 0 1.4em 1em; }, which causes 1.4em extra whitespace between page title and first paragraph (similar issue as bug 19567).
  1. In Vector, absolute-positioned elements are relative to #bodyContent (r52855), whose first child is #contentSub (first visible child actually, given that #siteSub is not displayed by default). The fact that #contentSub is always present and always has a bottom margin, but does not always have content causes the content edge of #bodyContent (and, consequently, its absolute-positioned descendants) to be unstable. Compare the position of the coordinates at [[de:Athen]] (empty #contentSub, coordinates below header line) with [[de:Athina]] (non-empty #contentSub, coordinates above header line).

Version: unspecified
Severity: enhancement

Details

Reference
bz24705

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:04 PM
bzimport set Reference to bz24705.
bzimport added a subscriber: Unknown Object (MLST).
Jdlrobson subscribed.

Is this whitespace really a problem? Given the age of this bug I'm going to guess no, but if yes, the skins can conditionally output it quite easily.
For future reference here is the line:
https://github.com/wikimedia/Vector/blob/master/includes/templates/skin.mustache#L58