Page MenuHomePhabricator
Create Task
Maniphest T267074

Tag, release, and use ObjectFactory 3.0.0
Closed, ResolvedPublic
Actions

Description

Changes since 2.1.0: https://github.com/wikimedia/object-factory/compare/v2.1.0...v3.0.0

Notable changes:
Support for optional services
Removed deprecated constructClassInstance method
Allow null values for 'services' spec field
Drop PHP 7.0/7.1 and HHVM support

Checklist:

  • Update HISTORY.md
  • Tag new version
  • Update Parsoid to accept either old or new version of ObjectFactory
  • Update vendor with new version of Parsoid
  • Update vendor and core with new version of ObjectFactory
  • Fix core to take advantage of new version of ObjectFactory
    • Update HookHandlers' additionalProperties schema in extension.schema.v1.json and extension.schema.v2.json (no such clear schema is included for the other fields that accept ObjectFactory specs)
    • Update HookContainer::getHandlers check for hooks called with noServices also object to optional_services being set
    • Update Router::createHandler to allow the optional_services key
    • Update documentation of onLoadExtensionSchemaUpdates hook to object to optional_services

Details

SubjectRepoBranchLines +/-
Update for object-factory v.3mediawiki/coremaster+26 -5
Upgrade wikimedia/object-factory from 2.1.0 to 3.0.0mediawiki/coremaster+11 -2
Upgrade wikimedia/object-factory from 2.1.0 to 3.0.0mediawiki/vendormaster+136 -79
Bump wikimedia/parsoid to 0.13.0-a17mediawiki/vendormaster+750 -431
Use directories in phan config, instead of a single file in object-factorymediawiki/services/parsoidmaster+12 -9
Accept 3.x version of ObjectFactory as well as 2.1+mediawiki/services/parsoidmaster+9 -1
Prepare for version 3.0.0 releasemediawiki/libs/ObjectFactorymaster+12 -4
Customize query in gerrit

Event Timeline

DannyS712 created this task.Nov 2 2020, 9:28 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptNov 2 2020, 9:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Nov 2 2020, 9:29 PM

Change 638057 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/libs/ObjectFactory@master] Prepare for version 3.0.0 release

https://gerrit.wikimedia.org/r/638057

gerritbot added a project: Patch-For-Review.Nov 2 2020, 9:29 PM
DannyS712 updated the task description. (Show Details)Nov 2 2020, 9:38 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Nov 2 2020, 11:16 PM

Change 638057 merged by jenkins-bot:
[mediawiki/libs/ObjectFactory@master] Prepare for version 3.0.0 release

https://gerrit.wikimedia.org/r/638057

DannyS712 updated the task description. (Show Details)Nov 2 2020, 11:17 PM
DannyS712 updated the task description. (Show Details)Nov 2 2020, 11:22 PM
DannyS712 removed a project: Patch-For-Review.Nov 2 2020, 11:25 PM
DannyS712 updated the task description. (Show Details)Nov 2 2020, 11:39 PM
DannyS712 updated the task description. (Show Details)Nov 2 2020, 11:42 PM
gerritbot added a comment.Nov 2 2020, 11:42 PM

Change 638058 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/services/parsoid@master] Dependencies: accept new version of ObjectFactory

https://gerrit.wikimedia.org/r/638058

gerritbot added a project: Patch-For-Review.Nov 2 2020, 11:42 PM
DannyS712 updated the task description. (Show Details)Nov 2 2020, 11:48 PM
gerritbot added a comment.Nov 3 2020, 11:34 PM

Change 638058 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Accept 3.x version of ObjectFactory as well as 2.1+

https://gerrit.wikimedia.org/r/638058

DannyS712 changed the task status from Open to Stalled.Nov 3 2020, 11:52 PM
DannyS712 updated the task description. (Show Details)

Stalling until next week's version of Parsoid is cut and vendor updated

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2020, 12:10 AM
gerritbot added a comment.Nov 4 2020, 3:08 PM

Change 639178 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Use directories in phan config, instead of a single file in object-factory

https://gerrit.wikimedia.org/r/639178

gerritbot added a project: Patch-For-Review.Nov 4 2020, 3:08 PM
gerritbot added a comment.Nov 4 2020, 11:55 PM

Change 639178 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Use directories in phan config, instead of a single file in object-factory

https://gerrit.wikimedia.org/r/639178

DannyS712 updated the task description. (Show Details)Nov 15 2020, 1:19 AM
gerritbot added a comment.Nov 17 2020, 1:09 AM

Change 641308 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17

https://gerrit.wikimedia.org/r/641308

DannyS712 changed the task status from Stalled to Open.Nov 17 2020, 1:34 AM
gerritbot added a comment.Nov 17 2020, 1:52 AM

Change 641308 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17

https://gerrit.wikimedia.org/r/641308

gerritbot added a comment.Nov 17 2020, 1:53 AM

Change 641316 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/vendor@master] Upgrade wikimedia/object-factory from 2.1.0 to 3.0.0

https://gerrit.wikimedia.org/r/641316

gerritbot added a comment.Nov 17 2020, 1:55 AM

Change 641317 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Upgrade wikimedia/object-factory from 2.1.0 to 3.0.0

https://gerrit.wikimedia.org/r/641317

Jdforrester-WMF updated the task description. (Show Details)Nov 17 2020, 1:55 AM
DannyS712 updated the task description. (Show Details)Nov 17 2020, 1:56 AM
gerritbot added a comment.Nov 17 2020, 5:27 AM

Change 641316 merged by jenkins-bot:
[mediawiki/vendor@master] Upgrade wikimedia/object-factory from 2.1.0 to 3.0.0

https://gerrit.wikimedia.org/r/641316

gerritbot added a comment.Nov 17 2020, 5:27 AM

Change 641317 merged by jenkins-bot:
[mediawiki/core@master] Upgrade wikimedia/object-factory from 2.1.0 to 3.0.0

https://gerrit.wikimedia.org/r/641317

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Nov 17 2020, 6:00 AM
gerritbot added a comment.Nov 17 2020, 6:15 AM

Change 641291 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Update for object-factory v.3

https://gerrit.wikimedia.org/r/641291

Jdforrester-WMF updated the task description. (Show Details)Nov 17 2020, 5:04 PM
gerritbot added a comment.Nov 17 2020, 5:35 PM

Change 641291 merged by jenkins-bot:
[mediawiki/core@master] Update for object-factory v.3

https://gerrit.wikimedia.org/r/641291

Jdforrester-WMF updated the task description. (Show Details)Nov 17 2020, 5:38 PM
Jdforrester-WMF subscribed.

Are we done here?

DannyS712 closed this task as Resolved.Nov 17 2020, 5:56 PM
DannyS712 claimed this task.
In T267074#6628148, @Jdforrester-WMF wrote:

Are we done here?

Yes, I think so - I look forward to making use of the new optional services feature!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL