Page MenuHomePhabricator

Wikitech static sync syslog spam
Closed, ResolvedPublic

Description

The wikitech sync on wikitech-static is spamming syslog with a ton of identical warnings, not sure of the impact on the sync itself.

The error is:

PHP Warning:  call_user_func() expects parameter 1 to be a valid callback, cannot access private method ImageBuilde
r::checkMissingImage() in /srv/mediawiki/w/includes/filerepo/FileRepo.php on line 1710

And this is a summary of its frequency:

# zgrep -c 'expects parameter 1 to be a valid callback' /var/log/syslog*
/var/log/syslog:0
/var/log/syslog.1:7395
/var/log/syslog.2.gz:8359
/var/log/syslog.3.gz:8881
/var/log/syslog.4.gz:8938
/var/log/syslog.5.gz:8938
/var/log/syslog.6.gz:8938
/var/log/syslog.7.gz:8437

Event Timeline

Volans triaged this task as Medium priority.Nov 3 2020, 9:37 AM
Volans created this task.

Change 638594 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Make ImageBuilder::checkMissingImage public

https://gerrit.wikimedia.org/r/638594

Change 638594 merged by jenkins-bot:
[mediawiki/core@master] Make ImageBuilder::checkMissingImage public

https://gerrit.wikimedia.org/r/638594

Change 638515 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@REL1_35] Make ImageBuilder::checkMissingImage public

https://gerrit.wikimedia.org/r/638515

Change 638515 merged by jenkins-bot:
[mediawiki/core@REL1_35] Make ImageBuilder::checkMissingImage public

https://gerrit.wikimedia.org/r/638515

Reedy claimed this task.

wikitech-static host updated too... Should resolve this issue

Thanks a lot @Reedy for the superquick turnaround! I'll check the logs tomorrow to confirm.