Page MenuHomePhabricator
Create Task
Maniphest T267114

Extract CRUD test Persistent assertion methods to a project wide usable PHPUnit Constraint.
Closed, ResolvedPublic
Actions

Description

$this->assertThat( $expectedPersistent, $testPersistent->accept( new IsSamePersistentFactory() );

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Extract reusable Persistent IsSame constraintsKarl Wettin (WMSE)mediawiki/extensions/WikispeechSpeechDataCollectormaster+1 K -174
Customize query in gerrit

Related Objects
Search...

Event Timeline

• kalle created this task.Nov 3 2020, 10:39 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 3 2020, 10:39 AM
gerritbot added a comment.Nov 3 2020, 2:09 PM

Change 638541 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Extract reusable Persistent IsSame constraints

https://gerrit.wikimedia.org/r/638541

gerritbot added a project: Patch-For-Review.Nov 3 2020, 2:09 PM
gerritbot added a comment.Nov 9 2020, 10:49 AM

Change 638541 merged by jenkins-bot:
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Extract reusable Persistent IsSame constraints

https://gerrit.wikimedia.org/r/638541

• kalle moved this task from Backlog to Done on the Wikispeech-Jobrunner (Sprint) board.Nov 12 2020, 8:15 AM
Lokal_Profil removed a project: Patch-For-Review.Nov 12 2020, 8:20 AM
Sebastian_Berlin-WMSE closed this task as Resolved.Nov 12 2020, 12:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits