Remove superfluous db freeResult calls
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Aug 7 2010, 1:59 PM

Description

Are all (or at least most) of the various freeResult calls on DB objects superfluous? i.e. Shouldn't code scope take care of them?

Details

Reference: bz24712

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Avoid using calls to freeResults() and allow object go out of scope	mediawiki/core	master	+0 -11

Customize query in gerrit

Related Objects

Mentioned Here: rMW46374a8e3e42: rdbms: Remove deprecated IDatabase functions

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:04 PM

• bzimport added a project: MediaWiki-libs-Rdbms.

• bzimport set Reference to bz24712.

• bzimport added a subscriber: Unknown Object (MLST).

Reedy created this task.Aug 7 2010, 1:59 PM

There's 116 or so in phase3 alone, and no doubt, many more in extensions

r70686 looks like Chad has done most of them...

Search "->freeResult" (14 hits in 4 files)

R:\Programming\SVN\mediawiki\trunk\phase3\includes\db\Database.php (1 hits)

Line 2788: $this->db->freeResult( $this );

R:\Programming\SVN\mediawiki\trunk\phase3\maintenance\convertLinks.inc (3 hits)

Line 60: $dbw->freeResult( $res );
Line 91: $dbw->freeResult( $res );
Line 131: $dbw->freeResult( $res );

R:\Programming\SVN\mediawiki\trunk\phase3\maintenance\convertLinks.php (3 hits)

Line 83: $dbw->freeResult( $res );
Line 114: $dbw->freeResult( $res );
Line 154: $dbw->freeResult( $res );

R:\Programming\SVN\mediawiki\trunk\phase3\maintenance\storage\checkStorage.php (7 hits)

Line 76: $dbr->freeResult( $res );
Line 129: $dbr->freeResult( $res );
Line 162: $dbr->freeResult( $res );
Line 183: $extDb->freeResult( $res );
Line 241: $dbr->freeResult( $res );
Line 279: $dbr->freeResult( $res );
Line 366: $extDb->freeResult( $res );

are you sure scope takes care of them?

Still valid in 1.21wmf8:

$:andre\> grep -r "\->freeResult" .
./includes/db/DatabaseUtility.php: $this->db->freeResult( $this );
./maintenance/storage/checkStorage.php: $dbr->freeResult( $res );
./maintenance/storage/checkStorage.php: $dbr->freeResult( $res );
./maintenance/storage/checkStorage.php: $dbr->freeResult( $res );
./maintenance/storage/checkStorage.php: $extDb->freeResult( $res );
./maintenance/storage/checkStorage.php: $dbr->freeResult( $res );
./maintenance/storage/checkStorage.php: $dbr->freeResult( $res );
./maintenance/storage/checkStorage.php: $extDb->freeResult( $res );
./maintenance/convertLinks.php: $dbw->freeResult( $res );
./maintenance/convertLinks.php: $dbw->freeResult( $res );
./maintenance/convertLinks.php: $dbw->freeResult( $res );

Krinkle updated the task description. (Show Details)Dec 10 2014, 2:13 PM

Krinkle added a project: Technical-Debt.

Krinkle set Security to None.

Krinkle removed subscribers: Unknown Object (MLST), Krinkle.

Krinkle subscribed.

Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2016, 11:50 PM

• demon unsubscribed.Mar 9 2017, 9:38 PM

Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:11 PM

Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jul 13 2018, 11:23 PM

Krinkle moved this task from Untriaged to Usage problem on the MediaWiki-libs-Rdbms board.Jul 28 2018, 10:16 PM

Change 498636 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Avoid using calls to freeResults() and allow object go out of scope

https://gerrit.wikimedia.org/r/498636

gerritbot added a project: Patch-For-Review.Mar 23 2019, 12:25 PM

hashar unsubscribed.Mar 23 2019, 5:15 PM

Change 498636 merged by jenkins-bot:
[mediawiki/core@master] Avoid using calls to freeResults() and allow object go out of scope

https://gerrit.wikimedia.org/r/498636

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 26 2019, 8:00 PM

Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM

Krinkle edited projects, added MediaWiki-General; removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), MediaWiki-libs-Rdbms.Jul 18 2019, 8:04 PM

Krinkle unsubscribed.