Missing in pretty much all files. Wait for all of APICrud-patches to be merged in.
Description
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • kalle | T267148 Include PHP file level /** @license GPL header to all files | |||
| Resolved | • kalle | T267116 Implement ApiCRUD, a non secure and generic data modification API. |
Event Timeline
Once decided, we need to update pretty much all classes in Speech Data Collector (which is lacking this annotation all together), and perhaps in the Wikispeech extension too.
I.e. adding this between the namespace statement and use statement:
/** * @file * @ingroup Extensions * @license GPL-2.0-or-later */
This was identified by Danny in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikispeechSpeechDataCollector/+/638485/1/includes/UUID.php
For MediaWiki-compatibility we chose GPL-2.0-or-later for Wikispeech. Anyhow the missing tags should probably all be added in a single patch. I thought being default for non-MediaWiki code, but can't find it.
@kalle Might also be worth taking a quick look at the Wikispeech repo to make sure this isn't missing from any of the files (spotted it on SpeechoidConnectorException)
Change 643700 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Cleanup PHP license file headers
A patch for Wikispeech SDC attached to this task will be created when ApiCRUD has been merged.
Change 643700 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Cleanup PHP license file headers
Change 667578 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Include PHP file level /** @license GPL header to all files
Change 667578 merged by jenkins-bot:
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Include PHP file level /** @license GPL header to all files