Page MenuHomePhabricator

Include PHP file level /** @license GPL header to all files
Closed, ResolvedPublic

Description

Missing in pretty much all files. Wait for all of APICrud-patches to be merged in.

Event Timeline

Once decided, we need to update pretty much all classes in Speech Data Collector (which is lacking this annotation all together), and perhaps in the Wikispeech extension too.

I.e. adding this between the namespace statement and use statement:

/**
 * @file
 * @ingroup Extensions
 * @license GPL-2.0-or-later
 */

This was identified by Danny in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikispeechSpeechDataCollector/+/638485/1/includes/UUID.php

For MediaWiki-compatibility we chose GPL-2.0-or-later for Wikispeech. Anyhow the missing tags should probably all be added in a single patch. I thought being default for non-MediaWiki code, but can't find it.

kalle renamed this task from What license do we annotate Wikispeech classes with? to Include PHP file level /** @license GPL header to all files.Nov 9 2020, 7:18 PM
kalle updated the task description. (Show Details)
kalle moved this task from 🤠 This week to 🥴 Backlog on the User-kalle board.
kalle removed a subscriber: Lokal_Profil.
kalle set the point value for this task to 1.Nov 12 2020, 8:50 AM

@kalle Might also be worth taking a quick look at the Wikispeech repo to make sure this isn't missing from any of the files (spotted it on SpeechoidConnectorException)

Change 643700 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Cleanup PHP license file headers

https://gerrit.wikimedia.org/r/643700

A patch for Wikispeech SDC attached to this task will be created when ApiCRUD has been merged.

Change 643700 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Cleanup PHP license file headers

https://gerrit.wikimedia.org/r/643700

Change 667578 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Include PHP file level /** @license GPL header to all files

https://gerrit.wikimedia.org/r/667578

Change 667578 merged by jenkins-bot:
[mediawiki/extensions/WikispeechSpeechDataCollector@master] Include PHP file level /** @license GPL header to all files

https://gerrit.wikimedia.org/r/667578

Lokal_Profil removed the point value 1 for this task.Mar 11 2021, 9:16 AM