Page MenuHomePhabricator

[SPIKE] When face detection fails, align lead image to top instead of center
Closed, ResolvedPublic

Assigned To
Authored By
Dbrant
Nov 4 2020, 5:28 PM
Referenced Files
F33914094: 20201113_235507.jpg
Nov 13 2020, 11:11 PM
F33914096: 20201113_235822.jpg
Nov 13 2020, 11:11 PM
F33914098: 20201113_235619.jpg
Nov 13 2020, 11:11 PM
F33899643: Screenshot_20201110-134819.png
Nov 10 2020, 12:52 PM
F33899632: Screenshot_20201110-134328.png
Nov 10 2020, 12:52 PM
F33899586: Screenshot_20201110-134155.png
Nov 10 2020, 12:52 PM
F33899595: Screenshot_20201110-134220.png
Nov 10 2020, 12:52 PM

Event Timeline

I’ve tried it out with quite a few articles and images, my impression is that the new solution works better. Especially in sports related images, like tennis:

BeforeAfter
Screenshot_20201110-134155.png (2×1 px, 958 KB)
Screenshot_20201110-134220.png (2×1 px, 694 KB)
Screenshot_20201110-134328.png (2×1 px, 913 KB)
Screenshot_20201110-134819.png (2×1 px, 655 KB)

The new solution also works better in the examples that @Klapi mentioned in T265575. @Klapi – in case you’re reading this – could you also try out a few articles and check how this looks and feels? You need to download this APK to see it in action. We’d appreciate your input!

CC @Dbrant @Sharvaniharan

👍 From my testing, aligning images to the top is better for the vast majority of cases. I say we go with it.

Hello, I do agree that in most cases new solution is better.

Left: current version, right: new one.

20201113_235507.jpg (2×2 px, 504 KB)

20201113_235822.jpg (2×2 px, 805 KB)

20201113_235619.jpg (2×2 px, 425 KB)

And my personal opinion: I prefer old view without search bar at the top of the article.

Thanks a lot!