Generated attribution HTML broken, shows mixed with encoded and decoded characters
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mikulabc
	Nov 4 2020, 6:10 PM

Description

How to reproduce:

Open https://en.wikipedia.org/wiki/All-on-4#/media/File:Nobel_Biocare_All-on-4_solution_image_1.jpg
Click on the Download icon "Download this file" in the bottom-right corner
Click on "You need to attribute the author"
Click on "HTML"
See the generated HTML below, it is mixed with encoded and decoded characters

By &lt;a href=&quot;//commons.wikimedia.org/w/index.php?title=User:Nobel_Biocare&amp;amp;action=edit&amp;amp;redlink=1&quot; class=&quot;new&quot; title=&quot;User:Nobel Biocare (page does not exist)&quot;&gt;Nobel Biocare&lt;/a&gt; - &lt;span class=&quot;int-own-work&quot; lang=&quot;en&quot;&gt;Own work&lt;/span&gt;, <a href="https://creativecommons.org/licenses/by-sa/3.0" title="Creative Commons Attribution-Share Alike 3.0">CC BY-SA 3.0</a>, <a href="https://commons.wikimedia.org/w/index.php?curid=25125707">Link</a>

Produces:

Fix proposal:

By <a href="//commons.wikimedia.org/w/index.php?title=User:Nobel_Biocare&action=edit&redlink=1" class="new" title="User:Nobel Biocare (page does not exist)">Nobel Biocare</a> - <span class="int-own-work" lang="en">Own work</span>, <a href="https://creativecommons.org/licenses/by-sa/3.0" title="Creative Commons Attribution-Share Alike 3.0">CC BY-SA 3.0</a>, <a href="https://commons.wikimedia.org/w/index.php?curid=25125707">Link</a>

Would produce:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	EmbedFileFormatter.getCreditHtml: do not escape author HTML	mediawiki/extensions/MultimediaViewer	master	+21 -17

Customize query in gerrit

Related Objects

Duplicates Merged Here: T278256: Double HTML escaping of attribution HTML code to copy (mw-widget-copyTextLayout field value of multimediaviewer-attr-html)
T348137: MediaViewer creates broken HTML for embedding an image (incorrectly encodes HTML markup)

Event Timeline

Mikulabc created this task.Nov 4 2020, 6:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 4 2020, 6:10 PM

Aklapper renamed this task from BUG: Generated attribution HTML is shown mixed with encoded and decoded characters to Generated attribution HTML broken, shows mixed with encoded and decoded characters.Nov 4 2020, 6:59 PM

Aklapper added projects: MediaViewer, Regression.

Raymond subscribed.Nov 13 2020, 1:44 PM

Raymond added subscribers: Jdlrobson, Diwanshu885.Nov 13 2020, 1:52 PM

Frank_Schulenburg subscribed.Nov 13 2020, 11:55 PM