Page MenuHomePhabricator

Javascript errors: Unable to add datalayers to map
Open, Needs TriagePublic

Description

Since some time, maps at Wikivoyage are incorrectly presented with missing markers if the map contains external mapshapes (geolines etc.) It seems that the mapserver does not return mapshape objects on async ajax requests.

The following errors occur in the Javascript console:

Unable to add datalayers to map. load.php:123:192
    jQuery 60
        initialize
        mightThrow
        process
        (Async: setTimeout handler)
    resolve
        fire
        fireWith
        fire
        fire
        fireWith
        process
        (Async: setTimeout handler)
    resolve
        fire
        fireWith
        fire
        fire
        fireWith
        mightThrow
        process
        (Async: setTimeout handler)
    resolve
        fire
        fireWith
        fire
        fire
        fireWith
        updateFunc
        fire
        fireWith
        tuple[0]
        mightThrow
        process
        (Async: setTimeout handler)
    resolve
        fire
        fireWith
        fire
        fire
        fireWith
        mightThrow
        process
        resolve
        mightThrow
        process
        (Async: setTimeout handler)
    resolve
        fire
        fireWith
        fire
        fire
        fireWith
        mightThrow
        process
        resolve
        mightThrow
        process
        (Async: setTimeout handler)
    resolve
        fire
        fireWith
        fire
        fire
        fireWith
        mightThrow
        process

And:

XHR GEThttps://maps.wikimedia.org/geoline?getgeojson=1&ids=Q5017773
[HTTP/2 404 Not Found 47ms]

XHR GEThttps://maps.wikimedia.org/geoline?getgeojson=1&ids=Q5017776
[HTTP/2 404 Not Found 62ms]

XHR GEThttps://maps.wikimedia.org/geoline?getgeojson=1&ids=Q5017773
[HTTP/2 404 Not Found 47ms]

XHR GEThttps://maps.wikimedia.org/geoline?getgeojson=1&ids=Q5017776

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Nov 5, 6:22 AM

Example: https://de.wikivoyage.org/wiki/Kairo/Ta%E1%B8%A5r%C4%ABr-Platz

The same error occurs on English Wikivoyage, too.

Restricted Application added a project: Operations. · View Herald TranscriptThu, Nov 5, 6:27 AM
RolandUnger added a comment.EditedThu, Nov 5, 6:38 AM

Some tests on https://de.wikivoyage.org/wiki/Kairo/Ta%E1%B8%A5r%C4%ABr-Platz

The map markers are not shown because of timeout of the map server and because of a programming failure in Mediawiki's Karthographer Javascript scripts. At the German Wikivoyage the are two scripts presenting maps. The Mediawiki scripts do nothing in case of timeout (see maps in article and full-screen maps). Below the map in the bottom right corner, there is a magnify button. If you press it the markers are shown because the map is presented in case of timeout, too. Three objects are missing: the Cairo metro lines from WMF's map server.

The map server returns a 404 error.

@MSantos this seems like a reordering of the deploy street broke the /geoline endpoints of maps.wikimedia.org ?

https://maps.wikimedia.org/geoline?getgeojson=1&ids=Q5017773

Simply returns: Cannot GET /geoline

MSantos added a subscriber: hnowlan.Thu, Nov 5, 1:49 PM

@TheDJ actually, geoshapes is not being able to connect to the database, maybe due to the recent OSM resync. My assumption is that the replicas in the eqiad cluster are still updating. cc/ @hnowlan

sdkim assigned this task to hnowlan.Thu, Nov 5, 6:33 PM
sdkim moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog board.

It is not the first time that the map server is not working properly (T231964, T226412). But these malfunctions should not block drawing map structures which are not fetched from the mapserver/OSM database. The non-database structures are drawn only after a successful fetching of geolines and geoshape objects. If the fetching failed then the drawing of non-database structures will be blocked because of errors of JavaScript promises. This should not happen in any case. That's why I propose the following two changes:

Promise.all( promiseArray )
	.then( function() { drawAll(); } )
	.catch( function() { drawAllNonOsmObjects(); } );

I think the promises are handled in Kartographer\lib\wikimedia-mapdata.js.

The maps clusters in both datacentres are now stable and these URLs appear to be working now. More accurate errors should probably be returned for these endpoints misbehaving.

MSantos edited projects, added Maps; removed Maps (Kartotherian).

It is not the first time that the map server is not working properly (T231964, T226412). But these malfunctions should not block drawing map structures which are not fetched from the mapserver/OSM database. The non-database structures are drawn only after a successful fetching of geolines and geoshape objects. If the fetching failed then the drawing of non-database structures will be blocked because of errors of JavaScript promises. This should not happen in any case. That's why I propose the following two changes:

Promise.all( promiseArray )
	.then( function() { drawAll(); } )
	.catch( function() { drawAllNonOsmObjects(); } );

I think the promises are handled in Kartographer\lib\wikimedia-mapdata.js.

@RolandUnger the problem is solved, but your proposed changes to make geoshapes more robust seems reasonable, could you update the task description to reflect that? Or create a new task for that so we can close this one?

TheDJ added a comment.Wed, Nov 25, 8:49 PM

This proposed change seems reasonable, but if I’m not mistaken, that codepath is shared between the static map generation and the Front-end... if we generate ‘half’ rendered static maps, then how long would these be cached (without a method to purge them) @MSantos ?

Ladsgroup added a subscriber: Ladsgroup.

This is not related to Traffic. If I'm missing something obvious, please re-add it.

This proposed change seems reasonable, but if I’m not mistaken, that codepath is shared between the static map generation and the Front-end... if we generate ‘half’ rendered static maps, then how long would these be cached (without a method to purge them) @MSantos ?

@TheDJ we could change cache max-age when we are serving incomplete data. If that's not enough we should start thinking about how to improve cache purging, what do you think?