Page MenuHomePhabricator

Section translation: Prefetch sentence translations
Closed, ResolvedPublic

Description

In the sentence selector step of Section translation, when a sentence is selected, there is a small delay before the translation from default MT service arrives. There is no progress indicator too.

We need to show a progress indicator and more importantly we need to aniticipate the selection of next sentences and prefetch it in background just like how we do in CX2

Event Timeline

Change 643376 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Prefetch translation for following sentence

https://gerrit.wikimedia.org/r/643376

Change 643376 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXSentenceSelector: Prefetch translation for following sentence

https://gerrit.wikimedia.org/r/643376

Change 643704 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Sentence Selector: Add loading indicator until translation fetched

https://gerrit.wikimedia.org/r/643704

Change 643704 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Sentence Selector: Add loading indicator until translation fetched

https://gerrit.wikimedia.org/r/643704

Jpita added a subscriber: Jpita.

I found an issue while testing this:

  • If I click the "Apply" button many times in a row, some sentences are not translated, even when the Apertium API calls are made correctly

@ngkountas does it get fixed on this ticket or should I create another one?

This comment was removed by ngkountas.