⚓ T267399 Drop default of ip_changes.ipc_rev

• Ladsgroup created this task.Nov 6 2020, 1:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2020, 1:10 PM

LSobanski added a subscriber: LSobanski.Nov 6 2020, 1:11 PM

Marostegui triaged this task as Medium priority.Nov 10 2020, 7:14 AM

Marostegui moved this task from Triage to Ready on the DBA board.

It can be done online, so no master failover required:

MariaDB [test]> ALTER TABLE /*_*/ip_changes ALTER COLUMN ipc_rev_timestamp DROP DEFAULT, ALGORITHM=INPLACE, LOCK=NONE;
Query OK, 0 rows affected (0.00 sec)
Records: 0  Duplicates: 0  Warnings: 0

Marostegui claimed this task.Nov 17 2020, 7:57 AM

Marostegui moved this task from Ready to In progress on the DBA board.

Marostegui updated the task description. (Show Details)

I have deployed this change to db2089:3316 and I will leave it a couple of days to make sure nothing breaks, replication-wise.

# for i in `cat /home/marostegui/git/mediawiki-config/dblists/s6.dblist | grep -v "#"`; do echo $i; mysql.py -hdb2089:3316 $i -e "show create table ip_changes\G" | grep ipc_rev_timestamp | grep binary;done
frwiki
  `ipc_rev_timestamp` binary(14) NOT NULL,
jawiki
  `ipc_rev_timestamp` binary(14) NOT NULL,
ruwiki
  `ipc_rev_timestamp` binary(14) NOT NULL,

Marostegui updated the task description. (Show Details)Nov 17 2020, 9:27 AM

Deployed on db1098:3316 - will leave it for a day to make sure nothing reads-related are affected by this change

Mentioned in SAL (#wikimedia-operations) [2020-11-18T07:45:19Z] <marostegui> Deploy schema change on db1098:3316 T267335 T267399

Stashbot mentioned this in T267335: Drop default of protected_titles.pt_expiry .Nov 18 2020, 7:45 AM

Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.Nov 18 2020, 11:35 AM

Marostegui updated the task description. (Show Details)Nov 19 2020, 6:53 AM

Marostegui updated the task description. (Show Details)Nov 19 2020, 2:06 PM

Marostegui updated the task description. (Show Details)Nov 23 2020, 6:59 AM

Marostegui updated the task description. (Show Details)Nov 23 2020, 7:16 AM

Marostegui updated the task description. (Show Details)Nov 23 2020, 8:14 AM

Marostegui updated the task description. (Show Details)Nov 23 2020, 8:18 AM

Marostegui updated the task description. (Show Details)Nov 23 2020, 8:23 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Nov 23 2020, 8:29 AM

Marostegui updated the task description. (Show Details)Nov 23 2020, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:53:45Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1141 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13367 and previous config saved to /var/cache/conftool/dbconfig/20201123-125345-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:54:17Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1141 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13368 and previous config saved to /var/cache/conftool/dbconfig/20201123-125417-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:57:59Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1143 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13369 and previous config saved to /var/cache/conftool/dbconfig/20201123-125759-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-23T12:58:16Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1143 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13370 and previous config saved to /var/cache/conftool/dbconfig/20201123-125815-marostegui.json

Marostegui updated the task description. (Show Details)Nov 23 2020, 12:59 PM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Nov 23 2020, 1:03 PM

Marostegui updated the task description. (Show Details)Nov 24 2020, 6:39 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Nov 24 2020, 6:45 AM

Marostegui updated the task description. (Show Details)

Marostegui updated the task description. (Show Details)Nov 24 2020, 6:50 AM

Marostegui updated the task description. (Show Details)Nov 24 2020, 6:59 AM

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:22:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1075 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13373 and previous config saved to /var/cache/conftool/dbconfig/20201124-072249-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:27:15Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1075 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13374 and previous config saved to /var/cache/conftool/dbconfig/20201124-072715-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:27:55Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1078 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13375 and previous config saved to /var/cache/conftool/dbconfig/20201124-072755-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:31:26Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1078 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13376 and previous config saved to /var/cache/conftool/dbconfig/20201124-073125-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:32:02Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1112 for schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13377 and previous config saved to /var/cache/conftool/dbconfig/20201124-073202-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2020-11-24T07:43:43Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repool db1112 after schema change T267335 T267399', diff saved to https://phabricator.wikimedia.org/P13378 and previous config saved to /var/cache/conftool/dbconfig/20201124-074342-marostegui.json

This is all done

Drop default of ip_changes.ipc_rev_timestamp
Closed, ResolvedPublic
Actions

Description

Related Objects

Event Timeline

Drop default of ip_changes.ipc_rev_timestampClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Drop default of ip_changes.ipc_rev_timestamp
Closed, ResolvedPublic
Actions