Page MenuHomePhabricator

Sunset/Archive Daddio skin
Closed, ResolvedPublic

Description

I had a look at Daddio and even when restoring a local copy of the ModernTemplate removed in Idb4caf8d9e1009126575c1416b047bad681293c7 it still fails to render.

Do we want to fix this ?

Here's a patch of how far I got during the effort to fix:

Archive Checklist

To-do list

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Nov 7, 12:01 AM
ashley added a subscriber: aaron.Sat, Nov 7, 12:36 AM

There aren't that many DOM differences between Daddio and Modern. Portlets (/skins/Modern/templates/Portlet.mustache) use h3 on Modern and h5 on Daddio. div#footer is wrapped in a new, separate div which has the ID mw_bottom, which is not present in Modern.

Besides those differences (and the custom CSS, obviously), here's a quick comparsion of the Daddio vs. Modern differences I found (based on both Daddio git master as well as my uncommitted, WIP, sorta-but-not-quite working code):

MediaWiki-skins-DaddioModern
ul#f-listul#footer-info
portlet_top CSS class in`div#p-personal`portlet CSS class in`div#p-personal`
no h2 in div#mw_portletsh2 element in div#mw_portlets
div#mw-contentdiv#content
#mw_header containing the h1 element inside div#mw_contentholder, before div#contentSub#mw_header containing the h1 element at the top of /skins/Modern/templates/skin.mustache
h5 element inside div#p-cactionsh3 element inside div#p-cactions

WikiApiary shows that Daddio is available on five wikis[sic], and the default skin on one of them, but actually only one of those sites (the site allegedly using Daddio as the default) is up & running MediaWiki, and though Daddio shows as installed on its Special:Version, it's not the default skin for that wiki, Vector is, and useskin=daddio does nothing on that wiki.

In light of these facts I'd support the skin's archival, but I think @aaron should weigh in as one of the named authors of the skin in question.

aaron added a comment.Fri, Nov 13, 6:47 AM

No objections here.

Jdlrobson renamed this task from Daddio skin is broken, Should we fix it or sunset it? to Sunset Daddio skin.Fri, Nov 20, 7:08 PM

Change 642505 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Daddio@master] Archive the Daddio skin

https://gerrit.wikimedia.org/r/642505

Peachey88 renamed this task from Sunset Daddio skin to Sunset/Archive Daddio skin.Sun, Nov 22, 4:26 AM
Peachey88 updated the task description. (Show Details)
Peachey88 added a subscriber: Peachey88.

I have added the started cleanup/archive checklist to ensure steps aren't missed.

Peachey88 moved this task from Backlog to delete on the Wikimedia-GitHub board.
Jdforrester-WMF updated the task description. (Show Details)

Change 643534 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[translatewiki@master] MediaWiki: Drop the 'Daddio' skin, archived

https://gerrit.wikimedia.org/r/643534

Change 643535 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [mediawiki/skins/Daddio] Archive

https://gerrit.wikimedia.org/r/643535

Change 643535 merged by jenkins-bot:
[integration/config@master] layout: [mediawiki/skins/Daddio] Archive

https://gerrit.wikimedia.org/r/643535

Change 643534 merged by jenkins-bot:
[translatewiki@master] MediaWiki: Drop the 'Daddio' skin, archived

https://gerrit.wikimedia.org/r/643534

Change 643536 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/skins@master] Archive the Daddio skin

https://gerrit.wikimedia.org/r/643536

Change 643536 merged by Jforrester:
[mediawiki/skins@master] Archive the Daddio skin

https://gerrit.wikimedia.org/r/643536

Jdforrester-WMF updated the task description. (Show Details)

Change 642505 merged by Jforrester:
[mediawiki/skins/Daddio@master] Archive the Daddio skin

https://gerrit.wikimedia.org/r/642505

Jdforrester-WMF closed this task as Resolved.Wed, Nov 25, 7:01 PM
Jdforrester-WMF assigned this task to Jdlrobson.
MGChecker updated the task description. (Show Details)Wed, Nov 25, 7:19 PM
MGChecker added a subscriber: MGChecker.

Diffusion needs some time to sync its mirrors so the skin is shown as archived here as well.

MGChecker updated the task description. (Show Details)Wed, Nov 25, 7:20 PM

Thanks James!

Thanks James!

Happy to help. Thanks for initiating this.