index.js:94
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Nov 7 2020, 9:17 AM

Description

Splitting from T258090#6328515 :

Steps:

Go to https://it.wikivoyage.org/wiki/Firenze#Basilica_di_Santa_Maria_Novella
Click blue box 1 to open https://it.wikivoyage.org/wiki/Firenze?debug=true#/maplink/4
Press Esc on keyboard

Result:
dialog.map is null in Firefox 82; TypeError: Cannot read property 'parentMap' of null in Chromium 86

Triggered by https://gerrit.wikimedia.org/g/mediawiki/extensions/Kartographer/+/fd5fa15d1a8ff6cd20b3b363b0fa2b9da430058d/modules/dialog/index.js#94

Details

	Subject	Repo	Branch	Lines +/-
	links and staticframes don't have parentMaps	mediawiki/extensions/Kartographer	master	+0 -9

Customize query in gerrit

Related Objects

Mentioned In: T258090: Kartographer map does not open on it.wikivoyage.org: "Blocked a frame from accessing a cross-origin frame"
Mentioned Here: T258090: Kartographer map does not open on it.wikivoyage.org: "Blocked a frame from accessing a cross-origin frame"

Event Timeline

Aklapper created this task.Nov 7 2020, 9:17 AM

Aklapper mentioned this in T258090: Kartographer map does not open on it.wikivoyage.org: "Blocked a frame from accessing a cross-origin frame".

Aklapper renamed this task from TypeError: Cannot read property 'parentMap' of null in to TypeError: Cannot read property 'parentMap' of null in modules/dialog/index.js:94.Nov 7 2020, 9:23 AM

Change 692704 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Kartographer@master] links and staticframes don't have parentMaps

https://gerrit.wikimedia.org/r/692704

gerritbot added a project: Patch-For-Review.May 18 2021, 8:19 PM

TheDJ claimed this task.May 18 2021, 8:20 PM

TheDJ triaged this task as Lowest priority.

TheDJ moved this task from Unsorted to General on the Maps (Kartographer) board.

Change 692704 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] links and staticframes don't have parentMaps

https://gerrit.wikimedia.org/r/692704

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.7; 2021-05-25).May 18 2021, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 18 2021, 11:10 PM

@TheDJ: Thanks a lot! Could this task be resolved or is there more to do?

@TheDJ: Hej! Can this task be resolved or is there more to do? Thanks.

TheDJ closed this task as Resolved.Sep 7 2021, 5:56 PM

TypeError: Cannot read property 'parentMap' of null in modules/dialog/index.js:94Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

TypeError: Cannot read property 'parentMap' of null in modules/dialog/index.js:94
Closed, ResolvedPublic
Actions