Page MenuHomePhabricator
Create Task
Maniphest T267467

Static vertical footer position ignores list length, overlaps with list, makes lists on Wikistats unreadable
Closed, ResolvedPublic
Actions

Description

The footer of Wikistats is moving onto the lists when scrolled down, thereby overlapping them, and making some of the information inaccessible.

Example pages:

  1. https://stats.wikimedia.org/#/all-wikisource-projects/contributing/top-editors/normal|table|last-month|~total|monthly
  2. https://stats.wikimedia.org/#/all-wikipedia-projects/contributing/top-editors/normal|table|last-month|~total|monthly

Screenshot:

Screenshot from 2020-11-07 15-57-57.png (640×1 px, 68 KB)

Short video (20 sec):
Wikistats Footer Bug, Nov 2020-2020-11-07_15.59.33.mp4735 KBDownload

Details

SubjectRepoBranchLines +/-
Disable chart movement on scrolling when on tableanalytics/wikistats2master+2 -1
Customize query in gerrit

Event Timeline

KCVelaga created this task.Nov 7 2020, 10:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2020, 10:31 AM
KCVelaga updated the task description. (Show Details)Nov 7 2020, 10:32 AM
Aklapper renamed this task from Footer is overlapping lists on Wikistats to Static vertical footer position ignores list length, overlaps with list, makes lists on Wikistats unreadable.Nov 7 2020, 7:46 PM

Indeed. That CSS puzzles me. A quick hack to at least see the table data would be to make the footer's position relative.

• fdans claimed this task.Nov 9 2020, 4:38 PM
• fdans added a project: Analytics-Kanban.
• fdans moved this task from Incoming to Wikistats on the Analytics board.Nov 9 2020, 4:43 PM
gerritbot added a comment.Nov 17 2020, 2:43 PM

Change 641434 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] Disable chart movement on scrolling when on table

https://gerrit.wikimedia.org/r/641434

gerritbot added a project: Patch-For-Review.Nov 17 2020, 2:43 PM
gerritbot added a comment.Nov 23 2020, 4:17 PM

Change 641434 merged by jenkins-bot:
[analytics/wikistats2@master] Disable chart movement on scrolling when on table

https://gerrit.wikimedia.org/r/641434

Maintenance_bot removed a project: Patch-For-Review.Nov 23 2020, 5:10 PM
• fdans moved this task from Next Up to Done on the Analytics-Kanban board.Dec 16 2020, 2:38 PM
• fdans closed this task as Resolved.Jan 25 2021, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL