Page MenuHomePhabricator

imagetransfer: UploadBot.run does not return a filename
Closed, ResolvedPublicBUG REPORT

Description

imagetransfer contains this code from compat:

bot = UploadRobot(url=url, description=description,
                  target_site=self.opt.target,
                  url_encoding=sourceSite.encoding(),
                  keep_filename=self.opt.keepname,
                  verify_description=not self.opt.keepname,
                  ignore_warning=self.opt.ignore_warning)
# try to upload
targetFilename = bot.run()

But bot.run() method does not return any filename; this seems broken long time ago

Event Timeline

Xqt renamed this task from Uplo to imagetransfer: UploadBot.run does not return a filename.Nov 9 2020, 4:35 PM
Xqt triaged this task as High priority.
Xqt added a project: Pywikibot.
Xqt updated the task description. (Show Details)

Change 640229 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] return last filename with UploadRobot.run()

https://gerrit.wikimedia.org/r/640229

Change 640229 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Do not use UploadRobot.run() with imagetransfer

https://gerrit.wikimedia.org/r/640229

Xqt claimed this task.