Page MenuHomePhabricator

The reply tool source mode jumps back and forth in Firefox 82.0.2
Closed, ResolvedPublic

Description

While making this comment, I was slightly annoyed by the fact that the interface jumped back and forth, which would make it impossible to focus on writing if I wasn't confident enough in my writing skills :-). See https://ctrlv.tv/nGaZ for a screencast. Not sure if it's reproducible.

Event Timeline

The issue is caused by the scrollbar appearing and disappearing. That text field is not supposed to have a scrollbar, since it resizes itself to match the text inside.

I couldn't reproduce it exactly, but at some zoom levels, I managed to get a scrollbar to appear consistently (although without the annoying effect where it flickers).

Change 640393 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Ensure scrollbar doesn't appear in source mode

https://gerrit.wikimedia.org/r/640393

Change 640393 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Ensure scrollbar doesn't appear in source mode

https://gerrit.wikimedia.org/r/640393

Thanks for your prompt fix, as always :).

By the way, on my Debian (“stretch”) using Firefox ESR, I pretty consistently get a scrollbar for every second line (i.e. if no scrollbar appears for an n lines long draft, it appears when the draft becomes n+1 lines long, disappears when it’s n+2 lines long, reappears when it’s n+3 lines long, and so on). Probably this was the case since the very beginning, I was just too lazy to report it… Thanks for reporting and fixing!

Change 653886 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Ensure scrollbar doesn't appear in source mode (for real)

https://gerrit.wikimedia.org/r/653886

Change 653886 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Ensure scrollbar doesn't appear in source mode (for real)

https://gerrit.wikimedia.org/r/653886

Ryasmeen added a subscriber: Ryasmeen.

Tested on BrowserStack on the page mentioned. Could not replicate the issue anymore there.