Page MenuHomePhabricator

Enhance smart_data_dump to support gathering metrics from both raid and standalone disks
Open, Needs TriagePublic


Currently, smart_data_dump will export metrics from the raid controller only if a host has both standalone disks and a raid controller:

# TODO(filippo): handle machines with disks attached to raid controllers _and_ regular sata
if not raid_drivers or raid_drivers == ['md']:
    for pd in noraid_list_pd():

In some cases, querying disks for mdraid/standalone can include disks attached to the raid controller. Raid controller metrics ought to be scraped by through the raid controller utility, therefore we need to filter out these raid-controller-attached disks and scrape metrics for the remainder as appropriate for mdraid or standalone disks.