Page MenuHomePhabricator
Create Task
Maniphest T267696

Add a link in VE: make the edit button in the context item open the link inspector when clicked
Closed, DeclinedPublic
Actions

Description

Currently, clicking the edit button does nothing. It should instead open VE's link inspector, but with the text field and the "External link" tab disabled.

Details

SubjectRepoBranchLines +/-
AddLink: Remove link edit button in link recommendation dialogmediawiki/extensions/GrowthExperimentsmaster+3 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Catrope created this task.Nov 10 2020, 11:49 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptNov 10 2020, 11:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2021, 6:15 PM
Tgr subscribed.Jan 22 2021, 7:07 AM

We are not planning link editing for the initial release, are we?

kostajh edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Jan 22 2021, 7:15 AM
kostajh subscribed.
In T267696#6767937, @Tgr wrote:

We are not planning link editing for the initial release, are we?

Right, sorry about that.

kostajh closed this task as Declined.Jan 22 2021, 7:16 AM
gerritbot added a comment.Jan 25 2021, 5:51 AM

Change 658074 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] AddLink: Remove link edit button in link recommendation dialog

https://gerrit.wikimedia.org/r/658074

gerritbot added a project: Patch-For-Review.Jan 25 2021, 5:51 AM
gerritbot added a comment.Jan 28 2021, 10:48 AM

Change 658074 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] AddLink: Remove link edit button in link recommendation dialog

https://gerrit.wikimedia.org/r/658074

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 28 2021, 11:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits