Don't hardcode ssl certificate name in profile::toolforge::docker::registry
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Nov 11 2020, 12:58 AM

Description

$ssl_certificate_name = 'toolforge'
acme_chief::cert { $ssl_certificate_name:
    before     => Class['::docker::registry'],
    puppet_rsc => Exec['nginx-reload'],
}

In toolsbeta the cert name should be toolsbeta. For now I worked around this by creating a toolforge named cert in toolsbeta, but that's a hack.

Details

	Subject	Repo	Branch	Lines +/-
	Make Toolforge docker registry cert configurable	operations/puppet	production	+1 -1

Customize query in gerrit

Event Timeline

Legoktm triaged this task as Lowest priority.Nov 11 2020, 12:58 AM

Legoktm created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2020, 12:58 AM

Change 666915 had a related patch set uploaded (by Majavah; owner: Majavah):
[operations/puppet@production] Make Toolforge docker registry cert configurable

https://gerrit.wikimedia.org/r/666915

gerritbot added a project: Patch-For-Review.Feb 25 2021, 3:26 PM

Change 666915 merged by Bstorm:
[operations/puppet@production] Make Toolforge docker registry cert configurable

https://gerrit.wikimedia.org/r/666915

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2021, 10:11 PM

Once the new hiera key is in place https://gerrit.wikimedia.org/r/plugins/gitiles/cloud/instance-puppet/+/45137d69386172e7c1587748277bfb243ab484dd%5E%21/#F0 should be undone.

taavi closed this task as Resolved.Nov 7 2021, 5:34 PM

taavi claimed this task.