Page MenuHomePhabricator
Create Task
Maniphest T267709

Include WikibaseManifest extension in Wikibase release packages
Closed, ResolvedPublic
Actions

Description

As a Wikibase Release manager I want to be publish releases of the WikibaseManifest extension, so that Wikibase users can use it easily on their installation.

This is meant as a first WMDE-maintained Wikibase extension added to the "release pipeline". There will likely be more. The way WikibaseManifest is added will likely serve as a "template" for further additions.

Open questions:

  • Should the Wikibase Manifest extension also be enabled by default in the provided Docker image?
  • Should we provide some extra environment vars or something to configure the WikibaseManifest settings

Acceptance Criteria:

  • WikibaseManifest is included in the tarball result of the "release pipeline" in a version which is compatible with the included version of Wikibase
  • WikibaseManifest is included in the Docker container image of the "release pipeline" in a version which is compatible with the included version of Wikibase

Notes

  • "in a version which is compatible with the included version of Wikibase" in the acceptance criteria above means that automated testing of integration of WikibaseManifest and the released version of Wikibase has happened during the releasing process

Related Objects

Event Timeline

WMDE-leszek created this task.Nov 11 2020, 6:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 11 2020, 6:13 AM
WMDE-leszek mentioned this in T267710: ["EPIC"] Create a "release pipeline" for Wikibase and releated software.Nov 11 2020, 6:30 AM
WMDE-leszek added a parent task: T267710: ["EPIC"] Create a "release pipeline" for Wikibase and releated software.
Tarrow updated the task description. (Show Details)Nov 11 2020, 2:58 PM
WMDE-leszek renamed this task from Add WikibaseManifest extension to Wikibase "release pipeline" to Include WikibaseManifest extension in Wikibase release packages.Jan 19 2021, 8:37 PM
WMDE-leszek removed a parent task: T267710: ["EPIC"] Create a "release pipeline" for Wikibase and releated software.
WMDE-leszek moved this task from Backlog to Ready for story writing on the Wikibase Release Strategy board.
• Samantha_Alipio_WMDE moved this task from Ready for story writing to Ready for breakdown on the Wikibase Release Strategy board.Feb 3 2021, 4:19 PM
• toan updated the task description. (Show Details)Feb 11 2021, 1:20 PM
• toan claimed this task.Mar 5 2021, 8:51 AM
• toan moved this task from Ready for breakdown to Sprint 2.1 on the Wikibase Release Strategy board.
• toan edited projects, added Wikibase Release Strategy (Sprint 2.1); removed Wikibase Release Strategy.
• toan moved this task from To do to Doing on the Wikibase Release Strategy (Sprint 2.1) board.
• toan moved this task from Doing to Peer Review on the Wikibase Release Strategy (Sprint 2.1) board.Mar 5 2021, 9:45 AM
hoo claimed this task.Mar 9 2021, 1:19 PM
hoo added a subscriber: • toan.
hoo moved this task from Peer Review to Done on the Wikibase Release Strategy (Sprint 2.1) board.Mar 9 2021, 9:28 PM
• toan added a subscriber: danshick-wmde.Mar 12 2021, 3:40 PM

@danshick-wmde

In LocalSettings.php

$wgEnableRestAPI = true; # <----- this is apparently up for deprecation
wfLoadExtension( 'WikibaseManifest' );

Should be all thats required for both REL1_35 and master.

after this you can find the endpoint at /w/rest.php/wikibase-manifest/v0/manifest

Reedy subscribed.Mar 12 2021, 3:44 PM

$wgEnableRestAPI is already a no-op in 1.35, and defaulting to true

/**
 * Enable the experimental REST API.
 *
 * @deprecated Since 1.35, defaults to true and is ignored by MediaWiki core itself.
 *             No longer functions as a setting. Will be removed in 1.36.
 */
$wgEnableRestAPI = true;
• toan mentioned this in T277168: Add documentation for all of the components added to Docker so far.Mar 12 2021, 3:53 PM
• toan added a comment.Mar 12 2021, 5:15 PM
In T267709#6908736, @Reedy wrote:

$wgEnableRestAPI is already a no-op in 1.35, and defaulting to true

/**
 * Enable the experimental REST API.
 *
 * @deprecated Since 1.35, defaults to true and is ignored by MediaWiki core itself.
 *             No longer functions as a setting. Will be removed in 1.36.
 */
$wgEnableRestAPI = true;

Thanks for that I'll update the readme in the repo

Reedy added a comment.Mar 12 2021, 5:16 PM

I've already put a patch up at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseManifest/+/671183 for that (and other README tweaks)

Along with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/671185 to remove it from core too

• toan added a comment.Mar 12 2021, 5:17 PM
In T267709#6909063, @Reedy wrote:

I've already put a patch up at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseManifest/+/671183 for that (and other README tweaks)

Along with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/671185 to remove it from core too

Awesome :)

WMDE-leszek closed this task as Resolved.May 10 2021, 7:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits