Page MenuHomePhabricator

Extension is instance core service ImportableOldRevisionImporter itself, but that is not part of stable policy/interface
Closed, ResolvedPublic2 Estimated Story Points

Description

FileImporter extension instance ImportableOldRevisionImporter in its own ServiceWiring (and tests).

The service is not part of the stable interface and the extension gets broken when new dependencies are added to the service

It seems only to set another logger, maybe make the service implement LoggerAwareInterface and allow to set the logger

Or I am wrong and core changes should be b/c?

https://codesearch.wmcloud.org/search/?q=new%5Cs%2BImportableOldRevisionImporter%5Cb&i=nope&files=&repos=

Event Timeline

Change 785167 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Replace custom core services with the originals

https://gerrit.wikimedia.org/r/785167

thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-04-13 board.
thiemowmde set the point value for this task to 2.

Change 785167 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Replace custom core services with the originals

https://gerrit.wikimedia.org/r/785167