Page MenuHomePhabricator

Search order can't be removed, but shows a remove button
Closed, ResolvedPublic

Description

Every search order, even the default one ("relevance"), is previewed as a little blob in the gray preview bar right below the search bar. There is an (x) button in the blob, but it doesn't do anything.

Screenshot from 2020-11-13 15-59-53.png (128×716 px, 8 KB)

We need to:

  1. Either visually disable or even remove the (x) button.
  2. Or make it work, i.e. it removes the blob and resets the sort order to the default.

However, option 2 only makes sense when we don't display the default search order ("relevance") in the first place. This is something that needs PM/UX approval.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Baseline:

  • Make the (x) button gray/disabled, because it is.
  • Possibly remove or hide the (x) button entirely.
  • Don't display the default sort order as a pill when the form is collapsed. The fact that "no special sort order is selected" will still be communicated simply because there is nothing special to see.
  • Change the text in the dropdown to say "Relevance (default)".

To be discussed:

  • Should the (x) be shown when the sort order is not the default, and reset it back to the default?

Closely related:

Fixed via T342245 (non-defaults can be removed now, the default is gray and can not be removed). If the default should be shown is still an open question (see https://gerrit.wikimedia.org/r/955883), but not necessary to consider this ticket done.