Page MenuHomePhabricator

Reply buttons disappear after using them once, when using with dtenable or user script hack
Closed, ResolvedPublic

Description

What happens:

  • Click [reply] button and reply to a comment.
  • Comment gets posted in the right place with an automatic signature (yay!)
  • All the [reply] buttons on the page disappear until you reload the page (boo)

What should happen:

  • Click [reply] button and reply to a comment.
  • Comment gets posted in the right place with an automatic signature (yay!)
  • See [reply] buttons all over the page, so you can reply to more comments!

Event Timeline

@Whatamidoing-WMF are you able to share a link to the particular page you experienced this on?

Note: I have not yet been able to reproduce this on this page: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Ppelberg-test#Testing_phab:T267847.

Hmm, it might not work correctly when using DiscussionTools on a wiki where it's not normally available (by using the user script or the URL parameter).

As discussed during today's team meeting, @matmarex is going to investigate this with an eye for whether this ticket might be related to T268093.

I think T268093 is actually not related. I tested and I can reproduce this problem only when using the URL parameter.

Change 641807 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix displaying reply links after posting a reply with dtenable=1

https://gerrit.wikimedia.org/r/641807

Esanders renamed this task from Reply buttons disappear after using them once to Reply buttons disappear after using them once, when using with dtenable or user script hack.Nov 22 2020, 10:42 PM

Change 641807 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix displaying reply links after posting a reply with dtenable=1

https://gerrit.wikimedia.org/r/641807

Looks like this will need to be tested next week when 1.36.0-wmf.20 lands considering the patch needs to be tested in production.


EDIT 4-Dec: still not yet ready to be tested on production.

ppelberg claimed this task.

Looks like this will need to be tested next week when 1.36.0-wmf.20 lands considering the patch needs to be tested in production.


EDIT 4-Dec: still not yet ready to be tested on production.

This seems to be working as expected.