Page MenuHomePhabricator

[reply] links appear using the MediaWiki “live preview” feature
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Enable live previews at PreferencesEditingShow previews without reloading the page on the wiki you want to test on.
  2. Go to any page.
  3. Open it for editing and place your signature it. (If you happened to choose a page already containing signatures, an extra one is not necessary.)
  4. Click on preview.

Actual Results:

  • Unstyled and not working [reply] buttons appear after the signatures.

Expected Results:

  • No [reply] links appear in edit preview.

Bonus:

  • Keep the preference on and be amazed how quickly previews load, that you can test CSS changes in the browser developer tools and not lose them after every preview, and so on. ;)

Event Timeline

I actually use the live preview feature, no idea how I never noticed this. I guess I stopped editing talk pages using the normal editor ;)

This is actually a bit awkward to fix, because in the hook which we're using to add the reply links, we don't know whether we're showing a normal page view or a preview. (Also – we don't have this for non-live preview either – now that I think of it, I have no idea how come we don't have the same problem there. This might be a separate bug that is accidentally cancelling out with our bug.)

It will probably be easier to fix after T267404: Add reply links to the parser cache, because we'll be able to access the parser options from our code then.

I guess I stopped editing talk pages using the normal editor ;)

Sometimes I need to start new sections, which is not yet supported. Otherwise yeah, same here.

It will probably be easier to fix after T267404: Add reply links to the parser cache, because we'll be able to access the parser options from our code then.

Okay, no hurry. Should we add that as a parent task to this task to make this dependency “official”?

I can’t reproduce it, either. Thanks for rechecking it!

ppelberg claimed this task.