Page MenuHomePhabricator

🐛 Bug | Banner displays on next page load after closing it
Closed, ResolvedPublic5 Estimated Story Points

Description

Steps to reproduce

  • Use the Chrome or Chromium.
  • Clear impCount cookies for wikipedia.de to make sure the banner impression limit won't prevent banner displays.
  • Clear cat cookie for wikipedia.de to reset banner display preventing cookie that is set after closing or donating.
  • Open www.wikipedia.de
  • Close the banner.
  • Reload the page.

Expected behaviour

  • The banner is not displayed.

Actual behaviour

  • The banner is displayed, ignoring that the previous banner was closed.

Notes

  • This is probably happening in wmde/banner-server
  • The banner impression limit (which seem to be based on similar logic) is working.

Event Timeline

Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptNov 16 2020, 9:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen updated the task description. (Show Details)Nov 16 2020, 9:23 AM
kai.nissen moved this task from Heap to Incubation on the WMDE-FUN-Funban-2020 board.
kai.nissen updated the task description. (Show Details)Nov 16 2020, 10:45 AM
kai.nissen updated the task description. (Show Details)
kai.nissen set the point value for this task to 5.

this was fixed by adding category: fundraising to each campaign WPDE campaigns config file
commit: https://github.com/wmde/wikipedia.de-banners/commit/7927ec9c6ef9de413100bc6294ac187240b3ccc0

kai.nissen closed this task as Resolved.Thu, Jan 7, 11:40 AM
kai.nissen claimed this task.