Track number of times TemplateData is changed in the editor vs. by writing JSON
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Lena_WMDE
	Nov 16 2020, 1:54 PM

Description

Track successful edits to template pages, …
… but only if the <templatedata> section (or the {{templatedata}} template in dewiki) was touched.
Additionally track if the TemplateData editor was opened before the page was saved. (The dialog might need to set a hidden bool that is send to the server when saving. Or find another way to combine these 2 dimensions. Might as well be possible to do it entirely on the client, i.e. hook into the save button.)
Ideally track if actual changes have been made in the editor, if possible. Otherwise just track the fact that the dialog was opened and confirmed at least once.

Other requirements:

Add the topic to the inclusion list for sanitization

Suggestion:

It sounds like there must be client-side code involved to track if the dialog was used. The server has no way to distinguish between manual and interactive edits otherwise.
To reduce complexity, try to do all tracking client-side.

Details

	Subject	Repo	Branch	Lines +/-
	Track when (relevant) changes are made to <templatedata> tags	mediawiki/extensions/TemplateData	master	+93 -2

Customize query in gerrit

Event Timeline

Lena_WMDE created this task.Nov 16 2020, 1:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2020, 1:54 PM

Lena_WMDE updated the task description. (Show Details)Nov 16 2020, 1:55 PM

Lena_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Nov 16 2020, 2:09 PM

thiemowmde updated the task description. (Show Details)Nov 20 2020, 10:14 AM

Lena_WMDE added a project: WMDE-QWERTY-Sprint-2020-11-18.Nov 20 2020, 11:18 AM

Lena_WMDE moved this task from In preparation to In sprint on the WMDE-Templates-FocusArea board.

I did a bit of investigation for this task. In the TemplateData extension, in TemplateDataHooks.php, there is a line $parser->getOutput()->setProperty( 'templatedata', … ) that stores a TemplateData blob in the page properties table. This code is executed after all templates are expanded, i.e. this will work with the German {{templatedata}} template.

The most trivial comparison might look like this:

$props = PageProps::getInstance()->getProperties( $title, 'templatedata' );
if ( $props && $props[ $title->getArticleID() ] !== $ti->getJSONForDatabase() ) {
	// TemplateData for this page changed
}

This compares the gzipped byte stream, i.e. this will track any change, even irrelevant changes to the formatting of the JSON. To avoid this, we could un-gzip and normalize both JSON blobs before comparing them.

thiemowmde claimed this task.Dec 1 2020, 8:26 AM

thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-11-18 board.

Change 644506 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TemplateData@master] Track when (relevant) changes are made to <templatedata> tags

https://gerrit.wikimedia.org/r/644506

gerritbot added a project: Patch-For-Review.Dec 1 2020, 11:45 AM

thiemowmde moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-11-18 board.Dec 1 2020, 12:49 PM

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-12-02.Dec 2 2020, 10:27 AM

Lena_WMDE moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-12-02 board.Dec 2 2020, 10:27 AM

Lena_WMDE set the point value for this task to 2.Dec 2 2020, 10:31 AM

thiemowmde moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2020-12-02 board.Dec 2 2020, 10:31 AM

thiemowmde moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-12-02 board.Dec 4 2020, 3:58 PM

awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-12-02 board.Dec 7 2020, 2:35 PM

awight moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.Dec 9 2020, 1:39 PM

thiemowmde closed this task as Resolved.Nov 3 2021, 9:30 AM