Page MenuHomePhabricator

Update text on Preferences > Appearance > Reading preferences
Closed, InvalidPublic

Description

Description

In T174726 the page previews setting (PreferencesAppearanceReading preferences) is being updated:

Proposed change is:

BeforeAfter
Screen Shot 2020-11-05 at 12.03.15 PM.png (340×2 px, 72 KB)
Screen Shot 2020-11-05 at 12.04.17 PM.png (258×1 px, 65 KB)

Once the preference has been merged for Page Previews & Reference previews we may want to update the text on the preferences page to make it clear that it is for both types of previews, e.g.

Screen Shot 2020-11-16 at 1.43.33 PM.png (136×774 px, 30 KB)

Event Timeline

@alexhollender Thanks for bringing this change to our attention. I'm not sure this needs it's own ticket, I think the mocks just need to be updated in this ticket to reflect the checkbox vs radio button design: T265709: Merge Page Preview and Reference Preview preferences. It includes both the preference merge and the changed wording to the 'Previews' title to cover both pop-ups.

@ECohen_WMDE right, good point. Perhaps we should update the first two mocks T265709 to reflect the checkbox vs the radio buttons? Just so folks don't get confused in the future? Happy to do that if it would be helpful.

Screen Shot 2020-11-17 at 9.17.10 AM.png (401×1 px, 120 KB)

@alexhollender agreed, would be good to have it all consistent. Thanks for offering, that would be great!