Media Search: Quick view image sizing bug
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	mwilliams
	Nov 16 2020, 10:47 PM

Description

This bug seems to only be on Chrome but I'm getting some sizing issues with the image within the quickview. There isn't a left and right margin and it is horizontally scrollable.

The image on the right is the expected design which is not scrollable and has left and right margins.

Details

	Subject	Repo	Branch	Lines +/-
	Improve image grid and fix QuickView thumbnail size	mediawiki/extensions/WikibaseMediaInfo	master	+158 -35

Customize query in gerrit

Event Timeline

mwilliams created this task.Nov 16 2020, 10:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2020, 10:47 PM

@egardner mentioned this as the potential culprit

I think that there is a difference in how FF vs Chrome handle auto image width; we might need to set a max-width of 100% on the quick view thumbnail element (.wbmi-quick-view__thumbnail--loaded) for proper behavior in Chrome

mwilliams renamed this task from Media Search: Quick view image bug to Media Search: Quick view image sizing bug.Nov 16 2020, 10:48 PM

mwilliams moved this task from Needs Design to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

mwilliams added a project: SDAW-MediaSearch (MediaSearch-ReleaseCandidate).

I'll fix this along with the grid work

AnneT claimed this task.Nov 18 2020, 3:59 PM

AnneT moved this task from Ready for Estimation to Doing on the Structured-Data-Backlog (Current Work) board.Nov 18 2020, 5:21 PM

Change 642521 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/WikibaseMediaInfo@master] Improve image grid and fix QuickView thumbnail size

https://gerrit.wikimedia.org/r/642521

gerritbot added a project: Patch-For-Review.Nov 20 2020, 8:18 PM

AnneT moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Nov 20 2020, 8:23 PM

Change 642521 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Improve image grid and fix QuickView thumbnail size

https://gerrit.wikimedia.org/r/642521

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 10:11 PM

AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Dec 2 2020, 10:13 PM

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Dec 3 2020, 9:48 PM