Page MenuHomePhabricator
Create Task
Maniphest T267981

Implement /revision/{id}/html endpoint in core
Closed, ResolvedPublic
Actions

Description

We already have /page/{title}/html and /page/{title}/with_html endpoints in core which provide access to Parsoid HTML for latest page revisions. We also need similar endpoints per revision. The response schema and all the caching requirements could be the same as for latest endpoints.

Details

SubjectRepoBranchLines +/-
Implement /revision/{id}/html endpointmediawiki/coremaster+1 K -153
Implement /revision/{id} endpointmediawiki/coremaster+345 -174
Introduce RevisionOutputCachemediawiki/coremaster+835 -240
Moved page/{title}/bare to PageSourceHandlermediawiki/coremaster+192 -60
Extract helper classes from PageHTMLHandlermediawiki/coremaster+1 K -398
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Nov 16 2020, 10:55 PM
• Pchelolo mentioned this in T262597: MediaWiki Developer stores revision HTML in parser cache.Nov 18 2020, 10:40 PM
• Pchelolo added a subtask: T262597: MediaWiki Developer stores revision HTML in parser cache.
• Pchelolo assigned this task to daniel.Nov 19 2020, 6:54 PM
daniel moved this task from Backlog to Ready on the Platform Team Workboards (Green) board.Nov 19 2020, 6:54 PM
gerritbot added a comment.Nov 21 2020, 5:14 PM

Change 642652 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: extract helper classes from PageHTMLHandler

https://gerrit.wikimedia.org/r/642652

gerritbot added a project: Patch-For-Review.Nov 21 2020, 5:14 PM
daniel moved this task from Ready to Doing on the Platform Team Workboards (Green) board.Nov 25 2020, 5:27 PM
daniel triaged this task as Medium priority.Nov 25 2020, 5:29 PM
gerritbot added a comment.Dec 2 2020, 6:40 PM

Change 642652 merged by jenkins-bot:
[mediawiki/core@master] Extract helper classes from PageHTMLHandler

https://gerrit.wikimedia.org/r/642652

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 7:11 PM
gerritbot added a comment.Dec 4 2020, 3:30 PM

Change 645385 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: Introduce RevisionOutputCache

https://gerrit.wikimedia.org/r/645385

gerritbot added a project: Patch-For-Review.Dec 4 2020, 3:30 PM

Change 645386 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: Implement /revision/{id}/html endpoint

https://gerrit.wikimedia.org/r/645386

daniel added a subtask: T269663: Implement parser output caching for /revision/{id}/html endpoint.Dec 8 2020, 10:14 AM
gerritbot added a comment.Dec 9 2020, 7:31 PM

Change 647341 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/core@master] Moved page/{title}/bare to PageSourceHandler

https://gerrit.wikimedia.org/r/647341

gerritbot added a comment.Dec 9 2020, 10:04 PM

Change 647341 merged by jenkins-bot:
[mediawiki/core@master] Moved page/{title}/bare to PageSourceHandler

https://gerrit.wikimedia.org/r/647341

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 9 2020, 11:00 PM
gerritbot added a comment.Dec 14 2020, 12:28 PM

Change 649310 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Implement /revision/{id} endpoint

https://gerrit.wikimedia.org/r/649310

• Pchelolo closed subtask T267982: Extract cached Parsoid access to an internal service object as Resolved.Dec 14 2020, 5:10 PM
• Pchelolo moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Dec 14 2020, 5:15 PM
• Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Dec 14 2020, 9:09 PM
gerritbot added a comment.Dec 14 2020, 9:17 PM

Change 645385 merged by jenkins-bot:
[mediawiki/core@master] Introduce RevisionOutputCache

https://gerrit.wikimedia.org/r/645385

gerritbot added a comment.Dec 14 2020, 9:23 PM

Change 645386 merged by jenkins-bot:
[mediawiki/core@master] Implement /revision/{id}/html endpoint

https://gerrit.wikimedia.org/r/645386

gerritbot added a comment.Dec 14 2020, 9:29 PM

Change 649310 merged by jenkins-bot:
[mediawiki/core@master] Implement /revision/{id} endpoint

https://gerrit.wikimedia.org/r/649310

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 10:10 PM
• ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Dec 15 2020, 4:11 PM
• ppelberg added a project: Editing-team (Tracking).
• ppelberg moved this task from Backlog to External on the Editing-team (Tracking) board.
• Pchelolo closed this task as Resolved.Dec 17 2020, 9:34 PM
• Pchelolo moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptDec 17 2020, 9:34 PM
• Pchelolo reopened this task as Open.Dec 17 2020, 9:35 PM
• Pchelolo moved this task from Done to Documentation on the Platform Team Workboards (Green) board.
• Pchelolo closed subtask T269663: Implement parser output caching for /revision/{id}/html endpoint as Resolved.Mar 2 2021, 3:27 PM
WDoranWMF closed subtask T262597: MediaWiki Developer stores revision HTML in parser cache as Resolved.Mar 2 2021, 4:28 PM
Aklapper added a project: Platform Engineering.Oct 18 2021, 7:42 AM

Adding Platform Engineering as Platform Team Workboards (Green) was archived and as open tasks should have an active project tag

WDoranWMF closed this task as Resolved.Nov 15 2021, 12:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL