Maniphest T267997

IPUtils doesn't allow /0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Nov 17 2020, 2:46 AM

Tags

Referenced Files

None

Subscribers

Description

I guess this is a revert of T247165: IPUtils allows illegal value for netmask (/0), ie I broke it...

https://s3.amazonaws.com/tr-learncanvas/docs/IP_Filtering_in_Canvas.pdf

CIDR block of/0 would allow access to any IP address between 0.0.0.0 and 255.255.255.255

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "Stop allowing invalid /0 subnet"	mediawiki/libs/IPUtils	master	+9 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Daimona	T218074 ip_in_range should accept explicit range notation
		Resolved		Jdforrester-WMF	T247212 Make new IPUtils release
		Resolved		Reedy	T267997 IPUtils doesn't allow /0

Event Timeline

Reedy created this task.Nov 17 2020, 2:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2020, 2:46 AM

Change 641289 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Revert "Stop allowing invalid /0 subnet"

https://gerrit.wikimedia.org/r/641289

gerritbot added a project: Patch-For-Review.Nov 17 2020, 2:46 AM

Change 641289 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Revert "Stop allowing invalid /0 subnet"

https://gerrit.wikimedia.org/r/641289

Maintenance_bot removed a project: Patch-For-Review.Nov 17 2020, 5:10 AM

Reedy mentioned this in rMLIP52893f63c7c5: Revert "Stop allowing invalid /0 subnet".Nov 17 2020, 5:20 AM

Reedy closed this task as Resolved.Jan 26 2021, 3:41 AM

Reedy claimed this task.

Reedy merged a task: T272948: /0 test failures.

Reedy added a parent task: T247212: Make new IPUtils release.

Reedy added a subscriber: Legoktm.

Reedy mentioned this in T247212: Make new IPUtils release.Jan 26 2021, 3:48 AM

Krinkle edited projects, added MediaWiki-libs-IPUtils; removed archived-IPUtils.Jan 3 2024, 3:05 PM