mw.util.getParamValue should return null not throw exceptions on input it cannot decode
Closed, ResolvedPublic
Actions

Description

Visit https://es.wikipedia.org/w/index.php?title=Autom%F3vil&diff=130998662
Run mw.util.getParamValue( 'title' ) in console

Expected: returns null per documentation
Actual: throws exception

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.11.17/clienterror/?id=AXXXeugsA-3rjFdAwOle

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.util: return null in getParamValue() if input fails to decode	mediawiki/core	master	+11 -2

Customize query in gerrit

Related Objects

Mentioned In: T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash

Event Timeline

Jdlrobson created this task.Nov 17 2020, 6:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2020, 6:58 PM

Jdlrobson mentioned this in T106244: URL encoded values using fallback 8-bit encoding (invalid UTF-8) cause mediawiki.Uri to crash.Nov 17 2020, 7:56 PM

Change 642500 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] mw.util.getParamValue should return null not throw exceptions on input it cannot decode

https://gerrit.wikimedia.org/r/642500

gerritbot added a project: Patch-For-Review.Nov 20 2020, 6:33 PM

Krinkle moved this task from Untriaged to Nov 2020 on the Wikimedia-production-error board.Nov 24 2020, 1:59 AM

Change 643361 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Forward errors to the global.error event so they are logged

https://gerrit.wikimedia.org/r/643361

Change 642500 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.util: return null in getParamValue() if input fails to decode

https://gerrit.wikimedia.org/r/642500

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Nov 25 2020, 4:00 AM

Jdlrobson closed this task as Resolved.Nov 25 2020, 6:21 PM

Jdlrobson claimed this task.

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).