Page MenuHomePhabricator

Minerva throws exceptions on certain reference links
Closed, ResolvedPublic


Scenario 1:

Expected: I jump to reference or I see reference dialog
Actual: An error is thrown*/logstash-2020.11.17/clienterror/?id=AXXW04dCG2-KaiAt-8eq

Uncaught URIError: malformed URI sequence
at decodeURIComponent

at getReference URL1:473:724
at showReference URL1:475:188
at showReference URL1:546:308
at onClickReference URL1:546:660
at dispatch URL1:151:747


Event Timeline

Jdlrobson renamed this task from Minerva throws exceptions on certain workflows to Minerva throws exceptions on certain reference links.Nov 17 2020, 7:02 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson triaged this task as Medium priority.Nov 18 2020, 10:47 PM
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

Broken functionality. Maybe high?

Krinkle added a subscriber: Krinkle.

Note that this one is coming from calling decodeURIComponent() - not involving mw.Uri afaik. I've added the error message, since that was missing.

Change 645199 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Allow display of references with already encoded URIs

Change 645199 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Allow display of references with already encoded URIs

I can verify this fix by looking at the error logs.

Test case is fixed in production.
No errors in last 12hrs

Screen Shot 2020-12-11 at 9.24.59 AM.png (416×2 px, 55 KB)