Page MenuHomePhabricator

Minerva throws exceptions on certain reference links
Closed, ResolvedPublic

Description

Scenario 1:

Expected: I jump to reference or I see reference dialog
Actual: An error is thrown

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.11.17/clienterror/?id=AXXW04dCG2-KaiAt-8eq

Error
Uncaught URIError: malformed URI sequence
at decodeURIComponent

at getReference URL1:473:724
at showReference URL1:475:188
at showReference URL1:546:308
at onClickReference URL1:546:660
at dispatch URL1:151:747

URL1: https://ja.m.wikipedia.org/w/load.php?lang=ja&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.centralautologin%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.relatedArticles.readMore.bootstrap%2Cgateway%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2Cthrottle-debounce%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2Cviewport%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmediawiki.ui.anchor%7Cmobile.init%2Cstartup%7Cmobile.messageBox.styles%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.externalguidance.init%7Cskins.minerva.icons.images.scripts%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.options%2Cscripts%7Cuser.defaults&skin=minerva&version=1gr9f

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.11.16/clienterror/?id=AXXS-XzcA-3rjFdA7sIS

Event Timeline

Jdlrobson renamed this task from Minerva throws exceptions on certain workflows to Minerva throws exceptions on certain reference links.Nov 17 2020, 7:02 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson triaged this task as Medium priority.Nov 18 2020, 10:47 PM
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

Broken functionality. Maybe high?

Krinkle added a subscriber: Krinkle.

Note that this one is coming from calling decodeURIComponent() - not involving mw.Uri afaik. I've added the error message, since that was missing.

Change 645199 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Allow display of references with already encoded URIs

https://gerrit.wikimedia.org/r/645199

Change 645199 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Allow display of references with already encoded URIs

https://gerrit.wikimedia.org/r/645199

I can verify this fix by looking at the error logs.

Test case is fixed in production.
No errors in last 12hrs

Screen Shot 2020-12-11 at 9.24.59 AM.png (416×2 px, 55 KB)