Page MenuHomePhabricator

Hard deprecate Html::infoBox
Closed, ResolvedPublic

Description

The method infoBox is only used in one place - the installer

https://codesearch.wmcloud.org/search/?q=Html%3A%3AinfoBox&i=nope&files=&repos=

Acceptance Criteria

  • Let's move the code into the installer and deprecate this method.
NOTE: The associated styles in resources/src/mediawiki.skinning/legacy.less will be removed as part of T89981 and are out of scope for this task.

Event Timeline

Change 641880 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Move Html::infoBox logic to WebInstaller

https://gerrit.wikimedia.org/r/641880

We definitely need to deprecate and change applications, as extensions like Translate uses mw-infobox right now.

Jdlrobson renamed this task from Deprecate Html::infoBox to Hard deprecate Html::infoBox.Nov 19 2020, 3:57 PM

Translate doesn't use Html::infoBox so won't be impacted by this particular deprecation. It is however relying on styles in mediawiki.skinning.legacy which are not always present (this will be broken on Minerva for example)

This is why we'll need to handle the styles deprecation separately.

Change 641880 merged by jenkins-bot:
[mediawiki/core@master] Move Html::infoBox logic to WebInstaller

https://gerrit.wikimedia.org/r/641880

Change 642583 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Html::infobox

https://gerrit.wikimedia.org/r/642583

Change 642583 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Html::infobox

https://gerrit.wikimedia.org/r/642583

Side-note: I had a hard moment to decipher “A/C” in the task description. “Air/Conditioning” :P