Hard deprecate Html::infoBox
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Nov 17 2020, 10:27 PM

Description

The method infoBox is only used in one place - the installer

https://codesearch.wmcloud.org/search/?q=Html%3A%3AinfoBox&i=nope&files=&repos=

Acceptance Criteria

Let's move the code into the installer and deprecate this method.

NOTE: The associated styles in resources/src/mediawiki.skinning/legacy.less will be removed as part of T89981 and are out of scope for this task.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Deprecate Html::infobox	mediawiki/core	master	+5 -0
	Move Html::infoBox logic to WebInstaller	mediawiki/core	master	+35 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T232903 The installer should use `.warningbox` for styling warnings, not `.mw-infobox`
		Resolved		Ammarpad	T268078 Hard deprecate Html::infoBox

Event Timeline

Jdlrobson created this task.Nov 17 2020, 10:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2020, 10:27 PM

Jdlrobson mentioned this in T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.Nov 17 2020, 10:33 PM

Jdlrobson moved this task from Phase 2 - Deprecate and remove Skin methods for readability to It's complicated on the MediaWiki-Core-Skin-Architecture board.Nov 18 2020, 5:16 PM

Jdlrobson mentioned this in T268194: Mark `.mw-infobox` CSS class removal from legacy.less in 1.37.Nov 19 2020, 2:25 AM

Change 641880 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Move Html::infoBox logic to WebInstaller

https://gerrit.wikimedia.org/r/641880

gerritbot added a project: Patch-For-Review.Nov 19 2020, 8:03 AM

We definitely need to deprecate and change applications, as extensions like Translate uses mw-infobox right now.

Jdlrobson renamed this task from Deprecate Html::infoBox to Hard deprecate Html::infoBox.Nov 19 2020, 3:57 PM

Jdlrobson added a parent task: T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.Nov 19 2020, 4:00 PM

Translate doesn't use Html::infoBox so won't be impacted by this particular deprecation. It is however relying on styles in mediawiki.skinning.legacy which are not always present (this will be broken on Minerva for example)

This is why we'll need to handle the styles deprecation separately.

Volker_E mentioned this in T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.Nov 20 2020, 3:56 PM

Change 641880 merged by jenkins-bot:
[mediawiki/core@master] Move Html::infoBox logic to WebInstaller

https://gerrit.wikimedia.org/r/641880

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).Nov 20 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2020, 5:10 PM

Jdlrobson moved this task from It's complicated to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Nov 20 2020, 7:50 PM

Change 642583 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Html::infobox

https://gerrit.wikimedia.org/r/642583

gerritbot added a project: Patch-For-Review.Nov 21 2020, 12:36 AM

Ammarpad claimed this task.Nov 21 2020, 12:39 AM

Change 642583 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Html::infobox