| Ryasmeen | |
| Nov 18 2020, 12:26 AM |
| F33918483: image.png | |
| Nov 18 2020, 6:14 PM |
| F33918488: image.png | |
| Nov 18 2020, 6:14 PM |
| F33918486: image.png | |
| Nov 18 2020, 6:14 PM |
Noticed this today, while doing regression testing on Reply tool. But, checked on Dutch wiki and it's already on production. So, not sure when it surfaced.
Steps to reproduce:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix client-side IDs for indistinguishable comments | mediawiki/extensions/DiscussionTools | master | +10 -6 |
There is another funny problem on that page: autosaved replies become attached to wrong comments.
E.g. try replying to the last comment:
Notably, the comments are both posted at the same time. There is clearly some problem in our code for distinguishing these comments.
@Ryasmeen Did you see this on any "real" pages, or only on test pages where you posted a lot of comments yourself?
Change 641810 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix client-side IDs for indistinguishable comments
There is another funny problem on that page: autosaved replies become attached to wrong comments.
E.g. try replying to the last comment:
Refresh the page:
The reply is now under a different comment:Notably, the comments are both posted at the same time. There is clearly some problem in our code for distinguishing these comments.
@Ryasmeen Did you see this on any "real" pages, or only on test pages where you posted a lot of comments yourself?
@matmarex: I am being able to reproduce this on this page as well: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Ppelberg-test#Testing:_repeated_commenting, where both me and @ppelberg posted multiple comments.
Change 641810 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix client-side IDs for indistinguishable comments