Page MenuHomePhabricator

[Regression] Reply link stops working after posting multiple comments
Closed, ResolvedPublic

Description

Noticed this today, while doing regression testing on Reply tool. But, checked on Dutch wiki and it's already on production. So, not sure when it surfaced.

Steps to reproduce:

  1. Go to this talk page: https://test.wikipedia.org/wiki/User_talk:RYasmeen_(WMF)/sandbox
  2. Reply to the comments "first", "second" and "third".
  3. Attempt to reply to the comment "fourth" by clicking on the reply link appended to it, notice nothing happens, the Reply Tool widget does not open.

Event Timeline

This comment was removed by Reedy.

There is another funny problem on that page: autosaved replies become attached to wrong comments.

E.g. try replying to the last comment:

image.png (2×3 px, 616 KB)

Refresh the page:
image.png (2×3 px, 627 KB)

The reply is now under a different comment:
image.png (2×3 px, 626 KB)

Notably, the comments are both posted at the same time. There is clearly some problem in our code for distinguishing these comments.

@Ryasmeen Did you see this on any "real" pages, or only on test pages where you posted a lot of comments yourself?

Change 641810 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix client-side IDs for indistinguishable comments

https://gerrit.wikimedia.org/r/641810

There is another funny problem on that page: autosaved replies become attached to wrong comments.

E.g. try replying to the last comment:

image.png (2×3 px, 616 KB)

Refresh the page:
image.png (2×3 px, 627 KB)

The reply is now under a different comment:
image.png (2×3 px, 626 KB)

Notably, the comments are both posted at the same time. There is clearly some problem in our code for distinguishing these comments.

@Ryasmeen Did you see this on any "real" pages, or only on test pages where you posted a lot of comments yourself?

@matmarex: I am being able to reproduce this on this page as well: https://en.wikipedia.beta.wmflabs.org/wiki/User_talk:Ppelberg-test#Testing:_repeated_commenting, where both me and @ppelberg posted multiple comments.

Change 641810 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix client-side IDs for indistinguishable comments

https://gerrit.wikimedia.org/r/641810

matmarex added a project: Editing QA.

Should be working correctly now (on Beta), please check!

ppelberg claimed this task.