Page MenuHomePhabricator

Stop consuming wikimedia-ui-base directly in bridge
Closed, DeclinedPublic

Description

Currently, the Wikidata Bridge project directly relies on the wikimedia-ui-base package for common design definition encoded in CSS variables (design tokens). This method, however, has been superseded with the introduction of wikit-tokens which uses these values inherited from wikimedia-ui-base, but also expands on them.

In order to ensure a single source of truth on our design tokens, we would like to remove this dependency on wikimedia-ui-base and update usages of design tokens from it, to those defined in wikit-tokens.

Acceptance Criteria:

  • wikimedia-ui-base has been replaced with wikit-tokens
  • design token usages have all been updated accordingly

Event Timeline

Disregard my above comment, this is still relevant. This is about wikimedia-ui-base, not wikibase-vuejs-components 🤦

To achieve this, we probably should rely on wikit tokens, I suppose. As they inherit from wikimedia-ui-base, but also expand on them. However, It's hard to tell what the motivation for this is without any added context. This ticket is quite sparse.

rely on wikit tokens

This is exactly what this ticket conceptually was about, yes. The rationale you gave hits the nail on its head. Thanks.

ItamarWMDE renamed this task from stop consuming wikimedia-ui-base directly in bridge to Stop consuming wikimedia-ui-base directly in bridge.Aug 3 2022, 1:48 PM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE updated the task description. (Show Details)

Declining this task since WiKit is now undergoing soft deprecation with a preference to migrate to codex. This task will be eventually superseded by the tasks of the following epic: T329761: [EPIC] Migrate Wikidata Bridge to Codex