Page MenuHomePhabricator
Create Task
Maniphest T268148

Retry submitting processMediaModeration jobs
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

processMediaModeration maintenance script sometimes fails on submitting the jobs. The jobs are submitted over HTTP, so it's no wonder it fails. We need to wrap JobQueueGroup::push with try-catch, catch the JobQueueError, retry a few times, log and keep going.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ModerateExistingFilesHelper: retry submitting processMediaModeration jobsVlad.shapikmediawiki/extensions/MediaModerationmaster+11 -3
Customize query in gerrit

Event Timeline

• Pchelolo created this task.Nov 18 2020, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2020, 4:21 PM
Helga_sf triaged this task as Medium priority.Nov 18 2020, 5:41 PM
Helga_sf edited projects, added: Platform Team Workboards (S&F Workboard); removed: Platform Team Workboards (Clinic Duty Team).
Helga_sf moved this task from Backlog to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.
• drochford subscribed.Dec 2 2020, 7:22 PM
Vlad.shapik claimed this task.Dec 3 2020, 1:52 PM
Vlad.shapik moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.
Vlad.shapik set the point value for this task to 4.Dec 9 2020, 6:34 PM
gerritbot added a comment.Dec 10 2020, 2:06 PM

Change 647713 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/MediaModeration@master] ModerateExistingFilesHelper: retry submitting processMediaModeration jobs

https://gerrit.wikimedia.org/r/647713

gerritbot added a project: Patch-For-Review.Dec 10 2020, 2:06 PM
Vlad.shapik moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Dec 10 2020, 2:34 PM
Vlad.shapik moved this task from In Progress/In Review to PM Sign Off on the Platform Team Workboards (S&F Workboard) board.Dec 10 2020, 4:14 PM
gerritbot added a comment.Dec 10 2020, 4:54 PM

Change 647713 merged by jenkins-bot:
[mediawiki/extensions/MediaModeration@master] ModerateExistingFilesHelper: retry submitting processMediaModeration jobs

https://gerrit.wikimedia.org/r/647713

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 10 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 10 2020, 5:10 PM
• eprodromou closed this task as Resolved.Dec 14 2020, 7:42 PM
• eprodromou subscribed.

Looks like it's merged; all good here.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits