Page MenuHomePhabricator

Make IPInfo available on mobile
Closed, ResolvedPublic1 Estimated Story Points

Description

IPInfo is currently only available on desktop. We can make it available on mobile too by adding the following to the ext.ipInfo module in extension.json:

"targets": [
    "desktop",
    "mobile"
]

Also see T288718: Spike: IP Info accordion: Shows both expand and collapse icons on mobile web [16 H]

Infobox on Contribs

There are two Contribs pages on mobile and we should display the information box on both.

NormalAdvanced setting enabled
image.png (748×1,332 px, 135 KB)
image.png (750×1,334 px, 109 KB)
Positon: The IP info box should appear after the For 101… line and before the Search box (same as desktop)Positon: The IP info box should appear after the IP address and before the dates start

The accordion itself will have the same information and order as the desktop version, the columns would appear one after the other instead of side-by-side:

image.png (680×1,900 px, 120 KB)

Popup

However, the OOUI PopupElement is buggy in mobile (which tends to use drawers instead), e.g.:

image.png (304×524 px, 14 KB)

@Prtksxna @Niharika Since the design is going to change anyway, would you be happy to defer enabling on mobile until after the design is finalised?

Details

Related Changes in Gerrit:

Event Timeline

@Prtksxna @Niharika Since the design is going to change anyway, would you be happy to defer enabling on mobile until after the design is finalised?

I think after we get community feedback we'd know for sure, but I am leaning towards the IP information being shown on Special Contribs instead of the popup. So yes, I think its a good idea to defer enabling it on mobile for now.

Since we have lesser space on mobile I'm thinking we should always have this box be collapsed on mobile. This would be inconsistent with desktop, what do you think @Niharika @Tchanders?

@Prtksxna Always collapsed makes sense to me. I think mobile is different enough in other ways that consistency here isn't necessary.

AGueyte set the point value for this task to 1.Apr 4 2022, 5:28 PM
WhitePhosphorus changed the task status from Open to Stalled.Jun 1 2022, 4:26 AM
WhitePhosphorus subscribed.

So this seems to be blocked by T180173 (popup widget displays incorrectly on small screens).

And regarding T309355#7962146: I think this feature is definitely good to have on mobile, since this can improve the anti-vandalism workflow. I know many people who are fighting against vandals in their small pockets of time, and to check IP info one would have to open an external page before we have this feature, which is kind of inconvenient on a cellphone.

WhitePhosphorus changed the task status from Stalled to Open.Aug 10 2022, 11:36 AM

I think it's ready to be deployed on mobile? Just make the IP info box always collapsed and do not touch the mw-ipinfo-infobox-expanded user preference if on mobile frontend.

I think it's ready to be deployed on mobile? Just make the IP info box always collapsed and do not touch the mw-ipinfo-infobox-expanded user preference if on mobile frontend.

+1 from me.

Change #1243108 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPInfo@master] IPInfo: Enable on mobile

https://gerrit.wikimedia.org/r/1243108

I assume this is ready for review?

Yes.

Change #1243108 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IPInfo: Enable on mobile

https://gerrit.wikimedia.org/r/1243108

dom_walden subscribed.

I have looked at the IPInfo infobox and popup on various pages on testwiki on a few different mobile devices.

The font size of the infobox heading on Special:Contributions seems inconsistent with the "Search for contributions" heading.

bs_ios_safari_18.jpg (358×709 px, 55 KB)

The location of the (i) on Special:RecentChanges can be jumbled (alongside other elements like Show IP and the UIC). I assume it is related to T404514.