Page MenuHomePhabricator

At the Italian Wikipedia, the unsigned edit templates aren't recognized unless they're subst:d
Closed, ResolvedPublic

Event Timeline

I was looking into T268589 and suddenly realized that this issue is also related. I tested locally and this is also already fixed by the patch rEDTOd0ae6c4e445e: Skip end marker "forward" until a block tag is reached (intended for T256033).

The problem was that the Italian Wikipedia's "unsigned" template ( has a full stop at the end (after the signature), and DiscussionTools was not considering it to be a part of the comment. So it looked like the comment's end was inside of the template, which meant that the reply would also have to be posted inside the template, which is obviously not allowed, so replying to those comments was disabled.

We should add a test case before marking this as resolved.

Change 643379 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add tests covering it.wp unsigned comment template

Change 643379 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add tests covering it.wp unsigned comment template

  • @matmarex: would it be accurate for me to assume this patch cannot be tested at until 10-December? [i]

i. it looks like the patch (643379) is "included in" wmf/1.36.0-wmf.20 and is still on wmf/1.36.0-wmf.18. See: .

Reply links are appearing and working as I'd expect them to on the page this issue was reported for:

Note: I've asked @ValeJappo on whether they are still experiencing this issue: .