Page MenuHomePhabricator
Create Task
Maniphest T268194

Mark `.mw-infobox` CSS class removal from legacy.less in 1.37
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
Volker_E
Nov 18 2020, 11:58 PM
Tags
Referenced Files
F33918654: image.png
Nov 18 2020, 11:58 PM
Subscribers
Aklapper
Iniquity
Jdlrobson
Volker_E

Description

image.png (682×2 px, 131 KB)
as seen at
.mw-infobox is not following system user messages styles guidelines

  • it is using a warning similar styling for a normal infobox
  • the border width and margins are single appearances

It should be standardized in appearance and evaluated if those styles are possible to be removed from legacy module.

Current usage
https://codesearch.wmcloud.org/search/?q=mw-infobox&i=nope&files=&repos=
https://gerrit.wikimedia.org/g/mediawiki/core/+/6e5c7e97b4e9ffc320371fba684954f72c6dce04/resources/src/mediawiki.skinning/legacy.less

  1. sign off steps
  2. Usage removed in Extension:Translate
  3. Usage removed in Extension:TranslateNotifications
  4. Make sure a task exists for removing this along with other styles in 1.37 (see T89981)

Details

SubjectRepoBranchLines +/-
Mark .mw-infobox styles as deprecatedmediawiki/coremaster+49 -17
Replace deprecated `mw-infobox` with Html::warningBoxmediawiki/extensions/TranslationNotificationsmaster+1 -5
Replace deprecated class "mw-infobox" with Html::warningBoxmediawiki/extensions/Translatemaster+3 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Nov 18 2020, 11:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2020, 11:58 PM
Jdlrobson added a parent task: T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.EditedNov 19 2020, 2:24 AM
Jdlrobson subscribed.

T268078 :)
Needed for the installer only. Can be removed.

Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.Nov 19 2020, 2:25 AM
Iniquity subscribed.Nov 19 2020, 2:35 AM

Dont forget about T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox` :)

Iniquity added a project: Tech Ambassadors & Translators.Nov 19 2020, 2:36 AM
Jdlrobson added a parent task: T232903: The installer should use `.warningbox` for styling warnings, not `.mw-infobox`.Nov 19 2020, 4:01 PM
Iniquity moved this task from Backlog to Mostly FYI (take action if you want) on the Tech Ambassadors & Translators board.Nov 19 2020, 4:28 PM
Jdlrobson moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Nov 20 2020, 7:10 PM
Jdlrobson moved this task from It's complicated to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.Nov 20 2020, 7:50 PM
gerritbot added a comment.Dec 10 2020, 7:00 PM

Change 647759 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Mark mw-infobox styles as deprecated

https://gerrit.wikimedia.org/r/647759

gerritbot added a project: Patch-For-Review.Dec 10 2020, 7:00 PM
Jdlrobson added a comment.Dec 10 2020, 7:01 PM

This will close out this particular task so we can focus on T232903

Jdlrobson renamed this task from Standardize and possibly remove mw-infobox from legacy.less to Mark mw-infobox removal from legacy.less in 1.37.Dec 10 2020, 7:02 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson updated the task description. (Show Details)
Volker_E renamed this task from Mark mw-infobox removal from legacy.less in 1.37 to Mark `.mw-infobox` CSS class removal from legacy.less in 1.37.Dec 15 2020, 1:25 PM
Volker_E added a project: CSS.
gerritbot added a comment.Dec 23 2020, 11:19 PM

Change 651849 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Translate@master] Replace deprecated class with core's warningbox

https://gerrit.wikimedia.org/r/651849

gerritbot added a comment.Dec 23 2020, 11:24 PM

Change 651853 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/TranslationNotifications@master] Replace deprecated mw-infobox with `messagebox

https://gerrit.wikimedia.org/r/651853

gerritbot added a comment.Jan 8 2021, 9:25 AM

Change 651849 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Replace deprecated class "mw-infobox" with Html::warningBox

https://gerrit.wikimedia.org/r/651849

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 8 2021, 10:00 AM
Jdlrobson added a project: TranslationNotifications.Jan 8 2021, 5:06 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jan 28 2021, 4:51 PM

Change 651853 merged by jenkins-bot:
[mediawiki/extensions/TranslationNotifications@master] Replace deprecated mw-infobox with Html::warningBox

https://gerrit.wikimedia.org/r/651853

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.29; 2021-02-02); removed MW-1.36-notes (1.36.0-wmf.26; 2021-01-12).Jan 28 2021, 5:00 PM
• Rileych added a project: Technical-Debt.Feb 1 2021, 3:05 PM
• Rileych moved this task from Backlog to Maintenance on the TranslationNotifications board.
Nikerabbit updated the task description. (Show Details)Feb 1 2021, 3:07 PM
gerritbot added a comment.Feb 9 2021, 1:13 PM

Change 647759 merged by jenkins-bot:
[mediawiki/core@master] Mark .mw-infobox styles as deprecated

https://gerrit.wikimedia.org/r/647759

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.31; 2021-02-16); removed MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Feb 9 2021, 2:00 PM
Jdlrobson closed this task as Resolved.Feb 9 2021, 10:44 PM
Jdlrobson mentioned this in T89981: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature.
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).
Jdlrobson updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL