Page MenuHomePhabricator

Wikisource: Add book's stylesheet to titlepage
Closed, ResolvedPublic3 Estimated Story Points

Description

NOTE: This ticket is dependent upon T264788 being completed first.

At the moment we generate titlepages that look something like this:

			<?xml version="1.0" encoding="UTF-8" ?>
			<!DOCTYPE html>
			<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" dir="ltr">
				<head>
					<title>Emma</title>
				</head>
				<body style="background-color: ghostwhite; text-align: center; margin-right: auto; margin-left: auto; text-indent: 0;">
					<h2>Emma</h2>
					<h3>Jane Austen</h3>
					<br /><img alt="" src="images/Accueil_scribe.png" /><br />
					<h5>1816</h5>
					<br />
					<h6>Exported from Wikisource on November 19, 2020</h6>
				</body>
			</html>

but every other page in the book has a head like this:

<head>
  <meta content="application/xhtml+xml;charset=UTF-8" http-equiv="default-style"/>
  <link type="text/css" rel="stylesheet" href="main.css"/>
  <title>Emma</title>
</head>

So (in EpubGenerator::getXhtmlTitle()) we need to add main.css to the title page.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ifried renamed this task from Add book's stylesheet to titlepage to Wikisource: Add book's stylesheet to titlepage.Dec 10 2020, 5:47 PM

We will first complete T264788 before working on this ticket.

ARamirez_WMF set the point value for this task to 3.Dec 10 2020, 6:49 PM
ARamirez_WMF moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.
dom_walden added a subscriber: dom_walden.

The stylesheet has been added to the title page.

It does not seem to have made much, if any, difference to how the title page looks.

It does not seem to have made much, if any, difference to how the title page looks.

The main functional difference is the inclusion of font-family, which means that ebooks with embedded fonts will use the same font for the titlepage as the rest of the book, which is good for fixing things like T258126.

This is on production, so I'm marking it as Done. We'll separately discuss T258126 and if any further action needs to be taken.