Page MenuHomePhabricator

Special:AbuseLog missing filter details line if revision is revision deleted
Closed, DuplicatePublic

Description

Specifically, the message abusefilter-log-detailedentry-meta is missing if the revision is revision deleted, but the viewer is an admin

Attempted debugging:
Looking at the dom shows that there is an empty <p> element where the info should be, and the only reason I could find for that to be the case would be https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/d7a1d9ac4c220515aa3bd7b554bd73e4dc11d959/includes/special/SpecialAbuseLog.php#1091

  • revision is rev-deled, so SpecialAbuseLog::isHidden returns 'implicit'
  • early return without the overall hit summary because 'implicit' is truthy
  • rest of the form is still shown because as a sysop I can see the underlying revision
  • fix is probably allowing $hidden to be 'implicit' if $isListItem is false

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The report implicitly assumes that you must be admin on meta. What I see is:

  • A normal entry for the first link
  • Nothing for the second link, with a message saying "You cannot view the details for this entry because its associated revision is hidden from public view."

Please provide screenshot to better explain what the problem is.

Also, this is surely a duplicate of/related to T233324, T262035, or T261532.

The report implicitly assumes that you must be admin on meta. What I see is:

  • A normal entry for the first link
  • Nothing for the second link, with a message saying "You cannot view the details for this entry because its associated revision is hidden from public view."

Please provide screenshot to better explain what the problem is.

Also, this is surely a duplicate of/related to T233324, T262035, or T261532.

Sorry, just saw this reply. I've updated the task description to reflect that this isn't only for metawiki (since I just ran into it again on simplewiki). For some reason I'm having trouble with screenshots on my computer at the moment, will try again later though