User-defined project domains should be validated
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	MusikAnimal
	Nov 19 2020, 6:40 AM

Description

Steps to Reproduce:

Go to Special:GlobalWatchlistSettings
Add the wiki "foobar" and Save settings
Go to Special:GlobalWatchlist

Actual Results:

You get the popup "GlobalWatchlist error, please check the console!"

Expected Results:

Shown errors when attempting to save the invalid wiki. Or, "foobar" could silently be ignored and not ever saved.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix return in SpecialGlobalWatchlistSettings::maybeGetValidSites	mediawiki/extensions/GlobalWatchlist	master	+1 -1
	Validate user-provided site list with CentralAuth	mediawiki/extensions/GlobalWatchlist	master	+125 -25

Customize query in gerrit

Related Objects

Mentioned In: rEGLWd44ab9567408: Fix return in SpecialGlobalWatchlistSettings::maybeGetValidSites
rEGLWbecb2a649d76: Validate user-provided site list with CentralAuth
T268261: Add a list or autocompletion for sites on Special:GlobalWatchlistSettings
T260860: Performance review of GlobalWatchlist
Mentioned Here: T268200: Beta cluster logstash down

Event Timeline

MusikAnimal created this task.Nov 19 2020, 6:40 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptNov 19 2020, 6:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DannyS712 triaged this task as Medium priority.Nov 19 2020, 6:49 AM

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Should be able to do in the next few days
Going to go with the show errors route, though validation will only be available if CentralAuth is installed.
To get the url forms of the wikis a user is attached on:

$urls = array_map(
	function ( $dbName ) {
		$wiki = WikiMap::getWiki( $dbName );
		return $wiki ? $wiki->getDisplayName() : '';
	},
	CentralAuthUser::getInstanceByName( 'DannyS712' )->listAttached()
);

(where DannyS712 is replaced with a variable for the acting user's name; can also use CentralAuthUser::getInstance with a user object)

DannyS712 mentioned this in T260860: Performance review of GlobalWatchlist.Nov 19 2020, 6:34 PM

DannyS712 moved this task from Backlog to In progress on the MediaWiki-extensions-GlobalWatchlist board.Nov 19 2020, 7:38 PM

Change 642091 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Validate user-provided site list with CentralAuth

https://gerrit.wikimedia.org/r/642091

gerritbot added a project: Patch-For-Review.Nov 19 2020, 7:46 PM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Nov 20 2020, 2:24 AM

DannyS712 mentioned this in T268261: Add a list or autocompletion for sites on Special:GlobalWatchlistSettings.Nov 22 2020, 1:49 AM

Change 642091 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Validate user-provided site list with CentralAuth

https://gerrit.wikimedia.org/r/642091

Urbanecm closed this task as Resolved.Dec 20 2020, 3:25 AM

Urbanecm assigned this task to DannyS712.

jenkins-bot mentioned this in rEGLWbecb2a649d76: Validate user-provided site list with CentralAuth.Dec 20 2020, 3:50 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 20 2020, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2020, 4:10 AM

Testing at https://meta.wikimedia.beta.wmflabs.org/wiki/Special:GlobalWatchlistSettings trying to add foobar
Sitelist:

meta.wikimedia.beta.wmflabs.org
en.wikipedia.beta.wmflabs.org
foobar

Actual result:
The site "meta.wikimedia.beta.wmflabs.org" does not match a wiki where you have an attached CentralAuth account.

tested with a few other inputs, its seems whatever I provide the first site fails as not matching.
However, testing via shell.php suggests that this should be working?

>>> $caU = CentralAuthUser::getInstance( User::newFromName( 'DannyS712' ) );
=> CentralAuthUser {#5273
     +mStateDirty: false,
     +mHomeWiki: null,
   }
>>> $urlForms = array_map( function ( $dbName ) { $wiki = WikiMap::getWiki( $dbName ); return $wiki ? $wiki->getDisplayName() : ''; }, $caU->listAttached() );
=> [
     "aa.wikipedia.beta.wmflabs.org",
     "api.wikimedia.beta.wmflabs.org",
     "ar.wikipedia.beta.wmflabs.org",
     "ca.wikipedia.beta.wmflabs.org",
     "commons.wikimedia.beta.wmflabs.org",
     "crh.wikipedia.beta.wmflabs.org",
     "cs.wikipedia.beta.wmflabs.org",
     "deployment.wikimedia.beta.wmflabs.org",
     "de.wikipedia.beta.wmflabs.org",
     "en-rtl.wikipedia.beta.wmflabs.org",
     "en.wikipedia.beta.wmflabs.org",
     "en.wikibooks.beta.wmflabs.org",
     "en.wikinews.beta.wmflabs.org",
     "en.wikiquote.beta.wmflabs.org",
     "en.wikisource.beta.wmflabs.org",
     "en.wikiversity.beta.wmflabs.org",
     "en.wikivoyage.beta.wmflabs.org",
     "en.wiktionary.beta.wmflabs.org",
     "eo.wikipedia.beta.wmflabs.org",
     "es.wikipedia.beta.wmflabs.org",
     "es.wikibooks.beta.wmflabs.org",
     "fa.wikipedia.beta.wmflabs.org",
     "he.wikipedia.beta.wmflabs.org",
     "he.wiktionary.beta.wmflabs.org",
     "hi.wikipedia.beta.wmflabs.org",
     "ja.wikipedia.beta.wmflabs.org",
     "ko.wikipedia.beta.wmflabs.org",
     "login.wikimedia.beta.wmflabs.org",
     "meta.wikimedia.beta.wmflabs.org",
     "ru.wikipedia.beta.wmflabs.org",
     "simple.wikipedia.beta.wmflabs.org",
     "sq.wikipedia.beta.wmflabs.org",
     "sv.wikipedia.beta.wmflabs.org",
     "test.wikipedia.beta.wmflabs.org",
     "wikidata.beta.wmflabs.org",
     "zh.wikipedia.beta.wmflabs.org",
     "zh.wikivoyage.beta.wmflabs.org",
   ]
>>> ExtensionRegistry::getInstance()->isLoaded( 'CentralAuth' )
=> true

will need to look into this more, though T268200: Beta cluster logstash down will make debugging a bit harder

Change 651220 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalWatchlist@master] Fix return in SpecialGlobalWatchlistSettings::maybeGetValidSites

https://gerrit.wikimedia.org/r/651220

gerritbot added a project: Patch-For-Review.Dec 22 2020, 4:00 AM

Change 651220 merged by jenkins-bot:
[mediawiki/extensions/GlobalWatchlist@master] Fix return in SpecialGlobalWatchlistSettings::maybeGetValidSites

https://gerrit.wikimedia.org/r/651220

jenkins-bot mentioned this in rEGLWd44ab9567408: Fix return in SpecialGlobalWatchlistSettings::maybeGetValidSites.Dec 23 2020, 2:58 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2020, 3:10 AM

DannyS712 closed this task as Resolved.Dec 23 2020, 4:08 AM

DannyS712 set Final Story Points to 4.

DannyS712 moved this task from In progress to Done on the MediaWiki-extensions-GlobalWatchlist board.Jun 13 2021, 3:35 PM