Page MenuHomePhabricator

"Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups
Closed, InvalidPublic

Description

"Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups

On a test wiki, the page [[User:Mark.Hershberger/widgeteditor's only approval]] that has one revision (mine) which contains only

{{#approvable_by: groups = widgeteditor }}

widget editors only

appears as this to me:

  • No link to latest
    • good, since there is only one revision
  • blank page with no approval link
    • good, I'm not an approver

Meanwhile, the page [[User:Mark.Hershberger/bot's only approval]] has three revisions, the first of which is approved and contains

{{#approvable_by: groups = bot }}

bots only

Visiting the page, it appears as:

  • No link to latest
    • bad, since there are revs after this

History for bots page:

  • Shows approval link for me and highlights approved rev
    • good
  • Approving latest rev takes me to the rev browser set to the latest rev and a notice that the page has been approved.
    • good

Visiting middle rev link shows:

  • No approve this page link
    • bad this rev isn't approved, I'm in the approval group, and the wiki shows "approve this revision" on other AR pages

Unapproved page [[Mark.Hershberger/Mark.himself]] with a single revision containing

{{#approvable_by: users = Mark.Hershberger }}

Mark only

shows

  • blank page with no approval link
    • bad this rev isn't approved, I'm in the approval group, no message about this not being approved, but being the latest revision and the wiki shows "approve this revision" on other AR pages

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2020, 4:41 PM

Note that changing my membership in the group does immediately add or remove the approve links from the history page.

I may have to eat my words. Setting up a test wiki with only

wfLoadExtension( 'ApprovedRevs' );
$wgGroupPermissions['sysop']['approverevisions'] = false;
$egApprovedRevsBlankIfUnapproved = true;
$egApprovedRevsShowNotApprovedMessage = true;

shows behavior more like what I expected. Reviewing all this now.

MarkAHershberger closed this task as Invalid.Nov 20 2020, 12:35 AM