Sometimes libup fails with an exception on updating/upgrading.
There should be a way to see failing repos
Maybe add an error symbol before the repo name on the lists (on https://libraryupgrader2.wmcloud.org/r and the subs)
Or add a new page with a list to see all at once.
This could make maintaince and tracking a bit easier.
Thanks.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Web: Show a ❌ next to errors repos in all view | labs/libraryupgrader | master | +13 -7 |
See https://libraryupgrader2.wmcloud.org/errors (sorry, I thought you already knew about that page)
I like putting an icon in the lists as well.
It seems not linked from anywhere or I missed it.
But thanks for the link
I usually looking at the package gets updated and than all repos not having the new version
Can you also look at https://libraryupgrader2.wmcloud.org/r/mediawiki/extensions/EventLogging where the web ui crashed?
The following repositories have some kind of error (as of now).
mediawiki/extensions/BlueSpiceBookshelfUI -> to archive, see T268085
mediawiki/extensions/DonationInterface -> using non default keys for eslint in Gruntfile.js
mediawiki/extensions/EventLogging - web UI crashed
mediawiki/extensions/LDAPSyncAll - fixed, hopefully passed tonight
mediawiki/extensions/MobileFrontend - T243788 - difference in versions of npm/nvm
mediawiki/extensions/Popups - T243788 - difference in versions of npm/nvm
mediawiki/extensions/StructuredNavigation - wrong php version (needs php7.4)
mediawiki/extensions/WikibaseMediaInfo - T243787 Use of @latest
mediawiki/libs/Equivset - T268271 xdebug missing
mediawiki/services/parsoid - T264326 eslint update to late or not done
Change 644911 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[labs/libraryupgrader@master] Web: Show a ❌ next to errors repos in all view
Change 644911 merged by jenkins-bot:
[labs/libraryupgrader@master] Web: Show a ❌ next to errors repos in all view
...
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: File "/srv/libraryupgrader/libup/web/templates/r.html", line 42, in block "main"
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: {% if library.is_newer() %}(<code>{{library.latest_version()}}</code> available{% if library.is_latest_safe() %}✔️{% endif %}){% endif %}
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: File "/srv/libraryupgrader/libup/library.py", line 88, in is_newer
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: return is_greater_than(self.version, self.latest_version())
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: File "/srv/libraryupgrader/libup/library.py", line 52, in latest_version
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: return self._metadata()['latest']
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: File "/srv/libraryupgrader/libup/library.py", line 49, in _metadata
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: }[self.manager](self.name)
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: File "/srv/libraryupgrader/libup/library.py", line 163, in _get_npm_metadata
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: 'latest': resp['dist-tags']['latest'],
Dec 05 06:47:21 upgrader-06 gunicorn[1466]: KeyError: 'dist-tags'Looks like the "eventgate-wikimedia": "git+https://gerrit.wikimedia.org/r/eventgate-wikimedia#536d5ef" dependency is causing an issue, let me see how to fix that.
Thanks, now it works and a update was committed.
It seems the web server needs restart to pick up the new code? I have not seen the new indicator in the UI yet.
I fixed this as part of https://gerrit.wikimedia.org/r/651662
I forgot that data.get_errors() returned a generator, not a list so you can't test it for inclusion.